-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(orgAdmin): Add org admin teaser in org team page for non-enterprise orgs #10253
Conversation
Hey @tianrunhe ! The screenshot looks good. I’m not able to see this locally. I have a team on the Starter plan. There are teams that either of 2 users aren’t on so they should see that there are hidden teams, yeah? I’m probably not doing something right. |
@ackernaut Are those teams under the same org? I can't seem to reproduce this. So, here I have user A, B & C in the same "Test Org" (starter tier) 👇 Each person is in their own's team: i.e., A has A's team with himself, B has B's team with himself, etc. All seems correct to me? |
Yep, I was on the wrong org. Turns out all the Terry’s Orgs aren’t the same 😆 . It looks good to me, nice work! How do you set up an Enterprise account locally? |
@ackernaut You can run the following mutation: mutation {
draftEnterpriseInvoice(orgId: "XXX", quantity: YY) {
...on DraftEnterpriseInvoicePayload {
organization {
name
}
}
}
} |
<Button | ||
variant='primary' | ||
shape='pill' | ||
className='bg-pink-500 hover:bg-pink-600 px-6 py-2 text-base text-white' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I personally find it to be too much on the nose. I know we want to encourage people to upgrade, but having this upgrade button so big and highlighted compared to the team rows feels like an ad. I think because it's very distinct from the other team rows already that it wouldn't harm to make the text paler and maybe smaller. @ackernaut what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m okay with subtle. We could yank the big button and put a link on Parabol Enterprise at the beginning of the sentence that takes them to the billing view. I think the text should stay the same to be legible in this case. Why make it hard to read why we are showing them the locked thing? I also think the lock icon could go a step down in scale so if it’s at 36 -> 24 or 24 -> 18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s an example in Figma cc @tianrunhe
Description
Fixes #10158
Demo
Testing scenarios
Enterprise org
http://localhost:3000/me/organizations/xxxx/teams
for anenterprise
orgStarter og
http://localhost:3000/me/organizations/xxxx/teams
for astarter
orgFinal checklist