Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rethinkdb): NewMeeting: Phase 3 #10273

Merged
merged 80 commits into from
Oct 8, 2024
Merged

chore(rethinkdb): NewMeeting: Phase 3 #10273

merged 80 commits into from
Oct 8, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Sep 24, 2024 •
edited
Loading

Description

removes writes to R

TODO

  • updateTeamInsights. is reduction a bigint?

NOTE: in staging, test for starting/end a poker & retro meeting & then goto timeline.

After running an equality checker, I found a couple diffs:

@mattkrick
chore: write to PG
bbd3d12 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix: refactor comment to SDL
217606e 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
add comment
fd13993 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into chore/Comment-phase1
918b493
@mattkrick
migrate existing Comments
424a54b 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
switch reads to PG
c0278ae 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix replies
4cf9c8f 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into chore/Comment-phase3
d61559a 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
init migration
da853e7
@mattkrick
add writes to PG
fb941f6
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase1
0efe604
@mattkrick
refactor add/move reflect template prompt to sdl
814d9ef
@mattkrick
refactor 4 mutations to sdl
134b3b6
@mattkrick
fix downmigration
2f8cf27 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase1
9f372a1
@mattkrick
use explicit columns
171ded7 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
migrate existing rows
a38beb4 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
progress
8a64083
@mattkrick
use explicit props
fcc66a9
@mattkrick
use explicit props nullable
c44f72c
@mattkrick
Merge branch 'chore/ReflectPrompt-phase1' into chore/ReflectPrompt-ph…
9c2b951 
…ase3
@mattkrick
remove writes to R
e628e0b 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix tsc
21fc97c 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
fix bad old migrations referencing types
ec73789 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'chore/ReflectPrompt-phase1' into chore/ReflectPrompt-ph…
d18a710 
…ase2
@mattkrick
Merge branch 'chore/ReflectPrompt-phase2' into chore/ReflectPrompt-ph…
551ce33 
…ase3

Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
chore: migrate PasswordResetRequest
726f632 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
use 2 queries for resets
9c7839d 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
clean up clientside sortOrder
89040df 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase2
5843139
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix nullability
a2c582e 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick marked this pull request as ready for review September 27, 2024 20:46
@mattkrick mattkrick changed the base branch from chore/NewMeeting-phase2 to master September 27, 2024 21:13
@mattkrick mattkrick changed the base branch from master to chore/NewMeeting-phase2 September 27, 2024 21:14
@mattkrick
handle empty arrays
882cb0b 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix typo
baec1ce 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix processRecurrence.test
e803ce7 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Base automatically changed from chore/NewMeeting-phase2 to master October 1, 2024 18:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix: bugs in self review
c1668ae 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
Merge branch 'master' into chore/NewMeeting-phase3
e3980ba 
Signed-off-by: Matt Krick <matt.krick@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick merged commit 1667810 into master Oct 8, 2024
6 checks passed
@mattkrick mattkrick deleted the chore/NewMeeting-phase3 branch October 8, 2024 17:41
@parabol-release-bot parabol-release-bot bot mentioned this pull request Oct 8, 2024
Merged
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattkrick