Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate insight from empty state #10323

Merged

Conversation

nickoferrall
Copy link
Contributor

Fix #10281

To test

  • Create a new team
  • Add the insight team feature flag by using the new addFeatureFlag and applyFeatureFlag mutations (see Notion doc)
  • Create two meetings and add content. You may want to remove some of the restrictions in getTopic like this

Screenshot 2024-10-09 at 18 38 22
Screenshot 2024-10-09 at 18 38 53

@nickoferrall nickoferrall linked an issue Oct 15, 2024 that may be closed by this pull request
2 tasks
@nickoferrall
Copy link
Contributor Author

Hey @Dschoordsch, i'd love to get this one reviewed so we can start using it internally 🙏

Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does not work for me though
image
I also find it confusing that an org scoped feature flag "insights" would not enable insights org wide, but only if I add it to each team.

@nickoferrall nickoferrall merged commit cfd8c78 into feat/10239/show-default-insight Oct 16, 2024
6 checks passed
@nickoferrall nickoferrall deleted the feat/10281/add-empty-state-insight branch October 16, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights: show empty state
2 participants