feat: add insights feedback UI modal #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hey @ackernaut, would you mind reviewing this one or letting me know if you're happy with the image in the description? 🙏 |
Base automatically changed from
feat/10281/add-empty-state-insight
to
feat/10239/show-default-insight
October 16, 2024 16:48
|
Hey, this is looking good! My only suggestion would be to make the Yes and No by the thumbs up/down semibold (600). They look a little light at that weight. Nice work! |
ackernaut
approved these changes
Oct 16, 2024
…rabol into feat/10242/add-feedback-ui
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10242
Figma: https://www.figma.com/design/eGGewFjqfNpfU3TUgaBSDo/Insights-UI-Views?node-id=0-1&node-type=canvas&t=nE2QY04nlO2K8R9H-0