Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): add metrics to identify who attempte to upgrade organization #10432

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Oct 30, 2024

Description

We have a long-term bug where we lost track of the user who has performed self-serve upgrade (we just record love@parabol.co did that). This has caused issue like this one.

This small PR is a walk around fix: we emit a new metric when a user attempted to upgrade. This way later in the data sanctum we can then join this new metric with the old Organization Upgraded metric to find the match.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe merged commit 62b610a into master Oct 30, 2024
8 checks passed
@tianrunhe tianrunhe deleted the fix/whoUpgraded branch October 30, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants