-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(orgAdmins): Update copy for Non Org Admins on Integration Settings page #10447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first looked at the gif, I thought it was taking the user to the Billing Leaders section. The issue is trying to avoid confusion between the Bililng Leader and the Org Admin, so I think that's a concern.
I then clicked "Org Admin Role", expecting it to explain something about the role, but it took me to my email.
Instead, what if we add a tooltip in Integration Settings explaining what "Org Admins" are, that they're an enterprise feature, and how they're different to Billing Leaders?
packages/client/modules/userDashboard/components/OrgBilling/OrgPlans.tsx
Outdated
Show resolved
Hide resolved
packages/client/modules/userDashboard/components/OrgIntegrations/OrgIntegrations.tsx
Outdated
Show resolved
Hide resolved
I think the purpose of the change is not only to explain what org admin roles are, but to also "tease" the customer for the greatness of the enterprise plan so they might consider upgrading. I'll leave this until @charlesmathias come back to make a decision 🤔. Thx for taking a look! |
Currently Integration settings are not limited by plan. The user just needs to be an Org Admin in order to access it. Eg, I have orgs on a trial (which is Team level access) with an Org Admin and that Org Admin can now manage org-level integrations. Considering that, sending them to the plans & billing page felt like the "simplest" way to for all (Starter, Team, Enterprise) non-Org Admin users to either:
Options I'd be happy to consider:
What do you both think? @tianrunhe @nickoferrall |
Ah I see on the Parabol org, the billing leader section shows a chip with the Org Admin role. Now I see why you wanted to send them there: I think including that Parabol help doc would be great. I'm not a fan of the Plans section sometimes showing Org Admin as a hyperlink and sometimes not, though. Happy to defer to Terry, but I don't like the inconsistency. How about:
|
I'm happy with that |
b91fab7
to
916d56c
Compare
packages/client/modules/userDashboard/components/OrgIntegrations/OrgIntegrations.tsx
Outdated
Show resolved
Hide resolved
Hey @tianrunhe and @nickoferrall. I released 8.4.2 but the last part of this PR isn't showing. The text is only "Organization-level integrations are managed by Org Admins." and it's missing the "View yours here". It wasn't blocking the release, but before opening an issue I wanted to be sure it's an actual issue. Please, could you verify in prod if the behavior is what you expected and let me know if it's not? Thanks |
Description
Fixes #10226
Demo
Testing scenarios
http://localhost:3000/me/organizations/xxx/integrations
Org Admins
CTAhttp://localhost:3000/me/organizations/xxx/billing?highlightOrgAdmin=true
and the page auto scroll into the plans sectionFinal checklist