Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(orgAdmins): Update copy for Non Org Admins on Integration Settings page #10447

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Nov 3, 2024

Description

Fixes #10226

Demo

2024-11-04 09 04 08

Testing scenarios

  • Scenario A
    • Select a non-enterprise org
    • Go to http://localhost:3000/me/organizations/xxx/integrations
    • Click Org Admins CTA
    • See you get redirected to http://localhost:3000/me/organizations/xxx/billing?highlightOrgAdmin=true and the page auto scroll into the plans section

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I first looked at the gif, I thought it was taking the user to the Billing Leaders section. The issue is trying to avoid confusion between the Bililng Leader and the Org Admin, so I think that's a concern.

I then clicked "Org Admin Role", expecting it to explain something about the role, but it took me to my email.

Instead, what if we add a tooltip in Integration Settings explaining what "Org Admins" are, that they're an enterprise feature, and how they're different to Billing Leaders?

@tianrunhe
Copy link
Contributor Author

tianrunhe commented Nov 4, 2024

Instead, what if we add a tooltip in Integration Settings explaining what "Org Admins" are, that they're an enterprise feature, and how they're different to Billing Leaders?

I think the purpose of the change is not only to explain what org admin roles are, but to also "tease" the customer for the greatness of the enterprise plan so they might consider upgrading.

I'll leave this until @charlesmathias come back to make a decision 🤔. Thx for taking a look!

@charlesmathias
Copy link

charlesmathias commented Nov 11, 2024

Instead, what if we add a tooltip in Integration Settings explaining what "Org Admins" are, that they're an enterprise feature, and how they're different to Billing Leaders?

Currently Integration settings are not limited by plan. The user just needs to be an Org Admin in order to access it. Eg, I have orgs on a trial (which is Team level access) with an Org Admin and that Org Admin can now manage org-level integrations.

Considering that, sending them to the plans & billing page felt like the "simplest" way to for all (Starter, Team, Enterprise) non-Org Admin users to either:

  • find out who their Org Admin is (without feeling like they're seeing an ad) or
  • find out how they can get access to Org Admin (while seeing that Org Admin is an Enterprise feature)

Options I'd be happy to consider:

  • changing the link on the P&B page to take a user here: https://www.parabol.co/support/roles-on-parabol/ instead of creating an email
  • changing the copy depending on the plan of the user in addition to whether they're an Org Admin. This feels like a bigger lift

What do you both think? @tianrunhe @nickoferrall

@nickoferrall
Copy link
Contributor

Ah I see on the Parabol org, the billing leader section shows a chip with the Org Admin role. Now I see why you wanted to send them there:

Screenshot 2024-11-11 at 15 17 50

I think including that Parabol help doc would be great.

I'm not a fan of the Plans section sometimes showing Org Admin as a hyperlink and sometimes not, though. Happy to defer to Terry, but I don't like the inconsistency.

How about:

  • On the integration settings page, include: "Organization-level integrations are managed by Org Admins. View yours here."
  • Org Admins is a hyperlink to the roles page
  • View yours here with "here" as a hyperlink to the billing leaders section in the Plans & Billing page
  • Plans section no longer has a hyperlink on Org Admins (or it always has a hyperlink to the roles page)

@charlesmathias
Copy link

I'm happy with that

@tianrunhe tianrunhe merged commit 33e2589 into master Nov 13, 2024
6 checks passed
@tianrunhe tianrunhe deleted the chore/orgAdminIntegrationSettings branch November 13, 2024 19:26
@rafaelromcar-parabol
Copy link
Contributor

Hey @tianrunhe and @nickoferrall. I released 8.4.2 but the last part of this PR isn't showing. The text is only "Organization-level integrations are managed by Org Admins." and it's missing the "View yours here". It wasn't blocking the release, but before opening an issue I wanted to be sure it's an actual issue.

Please, could you verify in prod if the behavior is what you expected and let me know if it's not? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copy for Non Org Admins on Integration Settings page
4 participants