-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update suggest group titles #10568
Conversation
packages/client/components/ReflectionGroup/ReflectionGroupTitleEditor.tsx
Show resolved
Hide resolved
const newGroupHasSmartTitle = reflectionGroup.title === reflectionGroup.smartTitle | ||
|
||
if (oldGroupHasSingleReflectionCustomTitle && newGroupHasSmartTitle) { | ||
// Edge case of dragging a single card with a custom group name on a group with smart name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the demo, I go through this edge case, which now works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 I think the intention here is: you have 2 groups: group 1 has a smart title and group 2 has only one reflection and a custom title. When we move the one card over to group 1, we want to also apply the custom title to group 1, at least that's happening on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Here's a Loom demo with that edge case: https://www.loom.com/share/e669008de75447ddafc7a303c14eca33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const newGroupHasSmartTitle = reflectionGroup.title === reflectionGroup.smartTitle | ||
|
||
if (oldGroupHasSingleReflectionCustomTitle && newGroupHasSmartTitle) { | ||
// Edge case of dragging a single card with a custom group name on a group with smart name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 I think the intention here is: you have 2 groups: group 1 has a smart title and group 2 has only one reflection and a custom title. When we move the one card over to group 1, we want to also apply the custom title to group 1, at least that's happening on master.
I've also updated the prompt and regex to remove |
Fix #10550
Demo: https://www.loom.com/share/8f9f18206aad44cba9bf1f3b9580f4fb
To test