-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restrict Timeline Feed scrolling to its column on /me route #10649
fix: Restrict Timeline Feed scrolling to its column on /me route #10649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nice for the timeline, but does break scrolling for active tasks if there are a lot of them, see loom
Alright, I am making the changes for that as well. |
ea3d2d3
to
a3f0aa8
Compare
@Dschoordsch I have fixed the Active Tasks as well. Please have a look Screen.Recording.2025-01-09.at.7.57.46.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. It works fine, but I don't like how it feels. Having two scrollbars feels too cluttered and I think we don't need the two separate scrolling contexts as I don't see a use case where a user needs to see a specific task and history event at the same time.
So what I think would be better is going back to the state of master and instead fix the "Active Tasks" column to run the full length, so that the border shows correctly and scrolling works regardless if there are more tasks or more history events.
Well, if you say, it's not important to see a specific event and history at the same time, then your proposition is correct. But I feel both things are separate entities, and should have their scrollable area. We have scrollable areas in tasks as well. Right ? I will surely do a POC about your proposition and see how things roll out. Will let you know about this. Let me know your thoughts, |
I agree these are 2 different things, but I don't think there is a use case where I want to see past event E together with a specific task T. Scrolling in a task is also not that nice and we should probably fix it to expand the task instead. If you feel strongly that we should scroll both independently, I would be interested in your use case. |
I got your point. Let's do this. I am updating the PR description as well. |
a3f0aa8
to
c9c5095
Compare
I think I like this layout as well. Have a look @Dschoordsch Screen.Recording.2025-01-10.at.11.55.01.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Yes, this looks much nicer without the scrollbar in the middle of the page.
Will merge it as soon as the tests pass.
Description
This PR fixes the issue where scrolling the Timeline Feed on the /me route would cause the "Active Tasks" column, to scroll as well. The Timeline Feed column now scrolls independently, ensuring the "Active Tasks" column remains static.
Fixes #10648
I had to remove the
overflow: 'auto'
from the FeedAndDrawer and add it to just theTimelineFeed
Demo
after-change.mov
Testing scenarios
Final checklist