Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

welcome wizard race condition Fix #914 #1089

Merged
merged 1 commit into from
Jun 27, 2017
Merged

welcome wizard race condition Fix #914 #1089

merged 1 commit into from
Jun 27, 2017

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Jun 18, 2017

testing the broken condition:

  • get to step 2 of the welcome wizard
  • move your mouse button to where the "kick the tires" button will appear
  • hit enter & very, very quickly click the mouse button
  • notice that the org wasn't created yet, so the no-payment modal pops up

with this patch, the delay occurs between step 2 and 3. this makes for a slower welcome wizard, but safer.

…id modal, but increases wait time to get to step 3.
@codecov
Copy link

codecov bot commented Jun 18, 2017

Codecov Report

Merging #1089 into master will decrease coverage by 12.36%.
The diff coverage is 18.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1089       +/-   ##
==========================================
- Coverage   58.26%   45.9%   -12.37%     
==========================================
  Files         123     169       +46     
  Lines        1699    2529      +830     
  Branches      238     399      +161     
==========================================
+ Hits          990    1161      +171     
- Misses        598    1113      +515     
- Partials      111     255      +144
Impacted Files Coverage Δ
.../universal/styles/helpers/makeFieldColorPalette.js 50% <ø> (ø)
.../universal/components/MentionEmoji/MentionEmoji.js 50% <ø> (ø)
src/universal/utils/emojiArray.js 100% <ø> (ø)
src/universal/styles/ui.js 100% <ø> (ø) ⬆️
src/universal/components/Button/Button.js 23.33% <ø> (ø)
src/universal/components/MentionTag/MentionTag.js 50% <0%> (ø)
.../components/EditorLinkChanger/changerValidation.js 0% <0%> (ø)
src/universal/utils/isProjectPrivate.js 0% <0%> (ø) ⬆️
src/universal/validation/legitify.js 57.35% <0%> (-3.59%) ⬇️
src/universal/utils/draftjs/addTagToProject.js 10% <10%> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec1860...3200a47. Read the comment docs.

@mattkrick mattkrick changed the base branch from master to staging June 27, 2017 00:30
@mattkrick mattkrick changed the base branch from staging to master June 27, 2017 00:30
@mattkrick mattkrick changed the title Fix 914 [merge after draftjs] welcome wizard race condition Fix #914 Jun 27, 2017
Copy link
Contributor

@jordanh jordanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordanh jordanh merged commit e71d061 into master Jun 27, 2017
@jordanh jordanh deleted the fix-914 branch June 27, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants