feat: can join public teams without invite #10952
Open
+215
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
requested review from
Dschoordsch
and removed request for
tianrunhe
Dschoordsch
approved these changes
Mar 10, 2025
Comment on lines
+36
to
+38
| if (!hasPublicTeamsFlag) { | ||
| return standardError(new Error('This team is not public')) | ||
| } |
There was a problem hiding this comment.
+1 not necessarily part of this change, but I think we might have an issue somewhere to allow org admins to join a team. Allowing them to bypass this check could solve this maybe.
Dschoordsch
requested changes
Mar 10, 2025
Dschoordsch
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10923
Demo: https://www.loom.com/share/43ab2b2fa5ea41b88eecfa71f7999a0f
I won't merge this until the other parts of the milestone are done.
To test