Thread comments expanded #4684
Merged
Thread comments expanded #4684
+36
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackernaut
commented
Feb 18, 2021
| @@ -22,7 +22,7 @@ import CommentEditor from './TaskEditor/CommentEditor' | |||
| import {ReplyMention, SetReplyMention} from './ThreadedItem' | |||
|
|
|||
| const Wrapper = styled('div')<{isReply: boolean; isDisabled: boolean}>(({isDisabled, isReply}) => ({ | |||
| alignItems: 'center', | |||
| alignItems: 'flex-end', | |||
There was a problem hiding this comment.
This keeps the avatar and the send button pinned to the bottom, instead of dynamically floating in the middle, when the input grows while adding a long comment
ackernaut
commented
Feb 18, 2021
| @@ -23,8 +23,6 @@ import useCommentPlugins from './useCommentPlugins' | |||
| const RootEditor = styled('div')({ | |||
| fontSize: Card.FONT_SIZE, | |||
| lineHeight: Card.LINE_HEIGHT, | |||
| maxHeight: 84, | |||
There was a problem hiding this comment.
Bye bye overflow and max-height 👋
|
@tiffanyhan mind giving this a review? This is almost too silly to test, but just in case my tired brain isn’t seeing a typo or bad style value, or bad behavior in the thread UI |
|
nice, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4647
Tests