-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals and DashAlert state #737
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9c26b5f
Notification bar state for UI
ackernaut 0974e05
Use layout value
ackernaut 3f569ab
Merge branch 'add-orgs' into add-orgs-modals-take2
ackernaut c0542ab
Legible UI contstants for modal layout
ackernaut b9b8a92
Merge branch 'master' into add-orgs-modals-take2
ackernaut fd55283
Merge branch 'master' into add-orgs-modals-take2
ackernaut 3b80f0d
Checking next props to update notibar state
ackernaut 293fec7
Checking for notification bar
ackernaut 8f8185c
Use state to check for dispatch
ackernaut 635a972
rerender less
mattkrick 0504735
Merge branch 'master' into add-orgs-modals-take2
ackernaut 538ca0c
Refactor NotiBar to DashAlert
ackernaut 404e356
Tweak dispatch name
ackernaut 963a542
Yank dispatch props, ensure bool
ackernaut e1efcf2
Yank dispatch from NewTeam component
ackernaut abc13ca
Restored dispatch on NewTeam container
ackernaut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
const DASH_ALERT_PRESENCE = 'dash/DASH_ALERT_PRESENCE'; | ||
|
||
const initialState = { | ||
hasDashAlert: false | ||
}; | ||
|
||
export default function reducer(state = initialState, action = {}) { | ||
switch (action.type) { | ||
case DASH_ALERT_PRESENCE: { | ||
return { | ||
...state, | ||
hasDashAlert: action.payload.hasDashAlert, | ||
}; | ||
} | ||
default: | ||
return state; | ||
} | ||
} | ||
|
||
export const setDashAlertPresence = (bool) => { | ||
const hasDashAlert = Boolean(bool); | ||
return { | ||
type: DASH_ALERT_PRESENCE, | ||
payload: { | ||
hasDashAlert | ||
} | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ackernaut can we get rid of this?