Markdown summary #794
Markdown summary #794
Conversation
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 63.92% 63.83% -0.09%
==========================================
Files 109 110 +1
Lines 1386 1391 +5
==========================================
+ Hits 886 888 +2
- Misses 500 503 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 58.71% 58.68% -0.03%
==========================================
Files 121 122 +1
Lines 1659 1663 +4
==========================================
+ Hits 974 976 +2
- Misses 685 687 +2
Continue to review full report at Codecov.
|
|
Meeting summary: |
|
Anyone know a good way to test whether the emails render markdown correctly? The meetingSummary and summaryEmail both use the same class to render so there should be no problem (Card.js) |
|
@ndey96, yes! Check out |
|
@jordanh Here is what the email looks like: |
| @@ -8,6 +8,7 @@ import {DragDropContext as dragDropContext} from 'react-dnd'; | |||
| import HTML5Backend from 'react-dnd-html5-backend'; | |||
|
|
|||
| const NewTeam = (props) => { | |||
| console.log(props); | |||
| @@ -19,7 +20,7 @@ const NewTeam = (props) => { | |||
| NewTeam.propTypes = { | |||
| dispatch: PropTypes.func.isRequired, | |||
| params: PropTypes.shape({ | |||
| newOrg: PropTypes.object | |||
| newOrg: PropTypes.string | |||
| @@ -53,6 +55,9 @@ const Card = (props) => { | |||
| }; | |||
| } | |||
|
|
|||
| const markdownCustomComponents = { | |||
There was a problem hiding this comment.
let's move this outside the component since it'll never change & then we can reuse that same object for all the cards.
|
@mattkrick made the changes you requested :) |
|
awesome! |
This addresses #728
It should:
@jordanh @mattkrick @ackernaut