Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #837, enhanced facilitator avatar #852

Merged
merged 4 commits into from
Mar 22, 2017
Merged

Conversation

ackernaut
Copy link
Member

@ackernaut ackernaut commented Mar 22, 2017

Adds two things:

  • Cranks up the warm circle a notch
  • Adds a Tag (label) below the Facilitator that says “Facilitator”

screenshot 2017-03-22 11 50 22

@codecov
Copy link

codecov bot commented Mar 22, 2017

Codecov Report

Merging #852 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #852   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files         122      122           
  Lines        1678     1678           
=======================================
  Hits          988      988           
  Misses        690      690
Impacted Files Coverage Δ
src/universal/styles/ui.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f691d0...dfd7b0b. Read the comment docs.

@mattkrick
Copy link
Member

LGTM. Only concern is whether the tag should be pink. that dark pink on light pink kinda makes me think error, maybe it's just me?

@ackernaut
Copy link
Member Author

Yeah, @mattkrick I see what you’re saying —I was just thinking of making the “warm” facilitator association even stronger. I would be okay trying the gray, or light yellow variants. What say ye?

@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2017

@ackernaut I think it's safe to try for a week or so. Let's go with it. It may get closer to the spirit behind #715 as well...

@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2017

Just tested it over here for real. It does really draw the eye up and away from the main action. Perhaps it isn't safe to try.

I've been using the inspector to try some changes:
image

Maybe yellow is the way to go?

image

@ackernaut
Copy link
Member Author

ackernaut commented Mar 22, 2017

@jordanh can you try just using the gray or light option for the colorPalette prop of Tag and see what you think?

@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2017

okey dokey

@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2017

This is tough choice. I also added a cool variant, for fun:

image

@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2017

Let's go with gray for now, and see where that leads...

@jordanh jordanh merged commit 6f86271 into master Mar 22, 2017
@jordanh jordanh deleted the enhance-facilitator-837 branch March 22, 2017 22:08
@jordanh jordanh removed the pr review label Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants