Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meeting-inception): implement add an activity button #8912

Merged
merged 6 commits into from
Oct 26, 2023
Merged

feat(meeting-inception): implement add an activity button #8912

merged 6 commits into from
Oct 26, 2023

Conversation

igorlesnenko
Copy link
Contributor

@igorlesnenko igorlesnenko commented Oct 3, 2023 •
edited
Loading

Fixes #8750

image

How to test:

  • Add meetingInception org level feature flag
  • Open various discussion panels, click on add an activity see it redirect to the activity library

@github-actions github-actions bot added the size/s label Oct 3, 2023
nickoferrall
nickoferrall approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@nickoferrall nickoferrall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review - I've been OOO for a few days.

LGTM! It looks like there's a build error that needs fixing before the PR can be merged though

packages/client/components/DiscussionThreadInput.tsx Show resolved Hide resolved
packages/client/components/AddActivityButton.tsx Outdated Show resolved Hide resolved
@igorlesnenko igorlesnenko requested a review from tghanken October 24, 2023 12:58
Dschoordsch
Dschoordsch approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the design. I haven't checked it with the zoom transcription UI update yet, but right now it looks a bit incohesive between the top, middle and bottom part of the panel
Screenshot 2023-10-24 at 17 49 38

packages/client/components/DiscussionThreadInput.tsx Outdated Show resolved Hide resolved
tghanken
tghanken approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@tghanken tghanken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Were you intending to add analytics as part of this PR or as part of a follow-on PR?

@igorlesnenko
Copy link
Contributor Author

@tghanken I was thinking to add something in this PR so we can track if users actually clicking on the button. Do we need something special for this?

tghanken
tghanken reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tghanken tghanken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only place we really need to add an event.

packages/client/components/DiscussionThreadInput.tsx Outdated
Comment on lines 352 to 354
onClick={() => {
window.open(`/activity-library/category/recommended`, '_blank', 'noreferrer')
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add an Add Activity Button Clicked event here.

@igorlesnenko igorlesnenko merged commit ca7384e into master Oct 26, 2023
@igorlesnenko igorlesnenko deleted the inception-add-activity branch October 26, 2023 07:37
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Merged
@sentry-io
Copy link

sentry-io bot commented Oct 30, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot destructure property 'id' of 'J' as it is undefined. J(packages/client/components/DiscussionThreadIn... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tghanken tghanken tghanken approved these changes

@nickoferrall nickoferrall nickoferrall approved these changes

@Dschoordsch Dschoordsch Dschoordsch approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meeting inception: add "add an activity" button
4 participants
@igorlesnenko @Dschoordsch @nickoferrall @tghanken