-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add SAML setup to new checkout flow #9178
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
import graphql from 'babel-plugin-relay/macro' | ||
import styled from '@emotion/styled' | ||
import {ElementWidth} from '../../../../types/constEnums' | ||
import React from 'react' | ||
import {PreloadedQuery, usePreloadedQuery} from 'react-relay' | ||
import {OrgAuthenticationQuery} from '../../../../__generated__/OrgAuthenticationQuery.graphql' | ||
|
@@ -8,6 +10,10 @@ import OrgAuthenticationMetadata from './OrgAuthenticationMetadata' | |
import OrgAuthenticationSSOFrame from './OrgAuthenticationSSOFrame' | ||
import OrgAuthenticationSignOnUrl from './OrgAuthenticationSignOnUrl' | ||
|
||
const StyledPanel = styled(Panel)<{isWide: boolean}>(({isWide}) => ({ | ||
maxWidth: isWide ? ElementWidth.PANEL_WIDTH : 'inherit' | ||
})) | ||
|
||
interface Props { | ||
queryRef: PreloadedQuery<OrgAuthenticationQuery> | ||
} | ||
|
@@ -17,6 +23,9 @@ const OrgAuthentication = (props: Props) => { | |
graphql` | ||
query OrgAuthenticationQuery($orgId: ID!) { | ||
viewer { | ||
featureFlags { | ||
checkoutFlow | ||
} | ||
organization(orgId: $orgId) { | ||
saml { | ||
...OrgAuthenticationSSOFrame_saml | ||
|
@@ -31,18 +40,19 @@ const OrgAuthentication = (props: Props) => { | |
queryRef | ||
) | ||
const {viewer} = data | ||
const {organization} = viewer | ||
const {organization, featureFlags} = viewer | ||
const {checkoutFlow} = featureFlags | ||
const saml = organization?.saml ?? null | ||
const disabled = !saml | ||
return ( | ||
<Panel> | ||
<StyledPanel isWide={checkoutFlow}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Normally we should adjust the design based on the parents, but as we're going to remove this flag soon, I just copied what we do in other places already. |
||
<DialogTitle className='px-6 pt-5 pb-6'>SAML Single Sign-On</DialogTitle> | ||
<OrgAuthenticationSSOFrame samlRef={saml} /> | ||
<div className={disabled ? 'pointer-events-none select-none opacity-40' : ''}> | ||
<OrgAuthenticationSignOnUrl samlRef={saml} /> | ||
<OrgAuthenticationMetadata samlRef={saml} /> | ||
</div> | ||
</Panel> | ||
</StyledPanel> | ||
) | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best solution, but consistent with
OrgMember
etc.