-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added option to modify icebreakers with ai #9268
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f236a8a
feat: added option to modify icebreakers with ai
BartoszJarocki 60336c4
code cleanup, analytics
BartoszJarocki 7cb71dd
code cleanup
BartoszJarocki 8ceee95
fix: added success property to icebreaker modified analytics event
BartoszJarocki 6498289
Merge branch 'master' into feat/ai-icebreakers
BartoszJarocki e1adbce
refactor: use relay mutation helper for modify check in question muta…
BartoszJarocki cc9e17e
feat: add modified question char limit
BartoszJarocki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
packages/client/mutations/ModifyCheckInQuestionMutation.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import graphql from 'babel-plugin-relay/macro' | ||
import {commitMutation} from 'react-relay' | ||
import {StandardMutation} from '../types/relayMutations' | ||
import {ModifyCheckInQuestionMutation as TModifyCheckInQuestionMutation} from '../__generated__/ModifyCheckInQuestionMutation.graphql' | ||
|
||
graphql` | ||
fragment ModifyCheckInQuestionMutation_meeting on ModifyCheckInQuestionSuccess { | ||
modifiedCheckInQuestion | ||
} | ||
` | ||
|
||
const mutation = graphql` | ||
mutation ModifyCheckInQuestionMutation( | ||
$meetingId: ID! | ||
$checkInQuestion: String! | ||
$modifyType: ModifyType! | ||
) { | ||
modifyCheckInQuestion( | ||
meetingId: $meetingId | ||
checkInQuestion: $checkInQuestion | ||
modifyType: $modifyType | ||
) { | ||
... on ErrorPayload { | ||
error { | ||
message | ||
} | ||
} | ||
...ModifyCheckInQuestionMutation_meeting @relay(mask: false) | ||
} | ||
} | ||
` | ||
|
||
const ModifyCheckInQuestionMutation: StandardMutation<TModifyCheckInQuestionMutation> = ( | ||
atmosphere, | ||
variables, | ||
{onCompleted, onError} | ||
) => { | ||
return commitMutation<TModifyCheckInQuestionMutation>(atmosphere, { | ||
mutation, | ||
variables, | ||
onCompleted, | ||
onError | ||
}) | ||
} | ||
|
||
export default ModifyCheckInQuestionMutation |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, relay's
useMutation
gives us those powers for free! would love to get more instances of the new pattern in the codebaseparabol/packages/client/mutations/useShareTopicMutation.ts
Line 32 in d5bcc37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg how could I miss that. old habits die hard, fixed!