Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure pool is callable after custom template migration #9572

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

nickoferrall
Copy link
Contributor

See Slack thread where the release initially failed: https://parabol.slack.com/archives/C836NA350/p1711538854886859

There was an error: Error: Cannot use a pool after calling end on the pool.

await pg.destroy() closes all db connections: https://kysely.dev/docs/getting-started

It looks like we should remove this line to keep the connection open.

@nickoferrall nickoferrall changed the title Fix: ensure pool is callable after custom template migration fix: ensure pool is callable after custom template migration Mar 27, 2024
@nickoferrall nickoferrall removed the request for review from mattkrick March 27, 2024 14:21
@nickoferrall nickoferrall changed the base branch from master to staging-backup March 27, 2024 14:21
@nickoferrall nickoferrall changed the base branch from staging-backup to master March 27, 2024 14:21
@mattkrick mattkrick merged commit 0d30206 into master Mar 28, 2024
8 of 9 checks passed
@mattkrick mattkrick deleted the fix/destroy-all-template-migration branch March 28, 2024 16:33
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants