Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix an issue where upcoming invoice doesn't have the nextPeriodCharges field #9580

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Mar 28, 2024

Description

Fixes #9578

After #9551 landed, we noticed that the UPCOMING invoices do not have the nextPeriodCharges field. The culprit is that the function that produces those future invoices, makeUpcomingInvoice, does not have a return type check. This fix imposes that and populate the required fields.

Demo

Screenshot 2024-04-02 at 17 50 02

Testing scenarios

  • Upcoming invoices
    1. Upgrade an org to team tier
    2. Observe the upcoming invoices are present correctly

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe marked this pull request as ready for review April 3, 2024 16:40
@Dschoordsch
Copy link
Contributor

Merging this now because I want to release it.

@Dschoordsch Dschoordsch merged commit cb52596 into master Apr 8, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the fix/nulNextPeriodCharges branch April 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoices are missing for team subscriptions
2 participants