Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue where timer doesn't work in TEAM_HEALTH phase #9597

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Apr 3, 2024

Description

Fixes #9540

Demo

2024-04-03 12 02 49

Testing scenarios

  • Timer present in team health phase
    • Start a retro meeting with team health option selected
    • Go to the team health phase
    • Start a timer
    • See the timer & count down properly shown up

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe merged commit 96f29b5 into master Apr 4, 2024
7 checks passed
@tianrunhe tianrunhe deleted the bug/9540/teamHealthTimer branch April 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-based (timer & time limit) feature in team health phase of retro does not work
2 participants