Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add favorite activities UI to activity library #9680

Merged
merged 13 commits into from
May 20, 2024

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Apr 29, 2024

Fix #9114

Demo: https://www.loom.com/share/9250b4b5414a4318a67aaf29a6a222cb

This PR won't be merged until the functionality is added in a subsequent PR.

To test

  • See the favourite icon in the activity library card
  • See that it only appears in the grid view
  • Clicking the favourite icon changes the colour. It becomes red
  • The heart emoji tab in the activity library is red and changes to white when active
  • Empty state looks like the design (I didn't include the "Your Favourite" title in the empty state as I didn't think it's needed)

@nickoferrall
Copy link
Contributor Author

Hey @ackernaut, would you mind reviewing the UI for this one, please?

Copy link
Member

@ackernaut ackernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks great, nice work Nick!

@nickoferrall nickoferrall merged commit d6a775d into master May 20, 2024
6 checks passed
@nickoferrall nickoferrall deleted the feat/9114/favorite-activities-ui branch May 20, 2024 17:12
@github-actions github-actions bot mentioned this pull request May 21, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Library v2: favourite activities UI
2 participants