Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase team subscription to $8 #9727

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented May 7, 2024

Description

Fixes #9707

Demo

Screenshot 2024-05-07 at 15 54 44

Testing scenarios

  • Team tier upgrade
    • Create a new org & a new team
    • Try to upgrade the org to team tier, observe the text is correctly updated from $6 to $8
    • Upgrade and make sure it works
    • Go to Stripe and verify the customer is correctly setup with the new $8 subscription (price app id: parabol-pro-800)

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe changed the title feat: increase team subscription to feat: increase team subscription to $8 May 7, 2024
@github-actions github-actions bot added the size/s label May 7, 2024
@tianrunhe tianrunhe requested a review from Dschoordsch May 7, 2024 13:00
@tianrunhe tianrunhe marked this pull request as ready for review May 7, 2024 13:00
@tianrunhe tianrunhe requested a review from Dschoordsch May 7, 2024 13:38
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. I did not verify the prod stripe settings.

One thing I noticed, also on master: when upgrading, I see the fireworks, but the buttons stays in the loading state "upgrading..." and I have to refresh the page to see the new invoice and setting. Do we already have an issue for this?

@tianrunhe tianrunhe merged commit 9d2fa5f into master May 8, 2024
5 checks passed
@tianrunhe tianrunhe deleted the feat/teamPriceIncrease branch May 8, 2024 11:24
@github-actions github-actions bot mentioned this pull request May 8, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pricing information in org views
2 participants