-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: team lead can view teams in org settings #9739
Conversation
Updated! In production, only billing leads can view the Teams page. So a user that is not the billing lead but has been promoted to team lead, can't see the Teams page. This PR fixes that. But a user could just create a new team in the org, be team lead of that new team, and then have access to the Teams page. The Teams page contains email information, which is why we restricted it before: Some options:
I lean towards options 1 or 3. What do you think? |
If we would show all teams on that page even when they're not a member, it's like having public teams, just a bit hidden. So I would lean towards 3+4: Everyone can see the team page, but users who are not billing lead or org admin can only see teams they're a member of. |
I like it! Updated 👍 |
Fix: #9738
To test