Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle invitation links with invalid auth token #9741

Merged
merged 1 commit into from
May 8, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented May 8, 2024

When following an invitation link with an old auth token, we would just show an ugly error message and don't give the user an action to do. Sign them out if we get the 'notSignedIn' error.

Demo

https://www.loom.com/share/76bd4fce2f7140fc929d82798d6310f6?sid=3b4d8953-ec62-4dd1-a0a1-639e4be6f945

Testing scenarios

  • Sign in
  • Close the tab
  • Restart the server with new secret
  • Follow an invite link

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

When following an invitation link with an old auth token, we would just
show an ugly error message and don't give the user an action to do. Sign
them out if we get the 'notSignedIn' error.
@Dschoordsch Dschoordsch merged commit 162de5e into master May 8, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the fix/handleAcceptingInvitesWithInvalidToken branch May 8, 2024 13:34
@github-actions github-actions bot mentioned this pull request May 8, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant