Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update plan upgrade CTA label #9769

Merged
merged 1 commit into from
May 23, 2024

Conversation

jordanh
Copy link
Contributor

@jordanh jordanh commented May 22, 2024

Description

I was running through the app on an un-upgraded team and noticed the CTA to upgrade under TeamSettings was "Upgrade Team to Team" which read a bit oddly to me. It wasn't clear that "Team" was a plan you could buy. Without reading the description text near the CTA, I would have thought, "wait, isn't my team already a team?"

This trivial change changes the CTA to read "Upgrade to Team Plan"

Adding @nickoferrall to the PR review just in case there was some intention behind this CTA I missed

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@jordanh jordanh requested a review from nickoferrall May 22, 2024 18:31
@jordanh jordanh added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label May 22, 2024
@github-actions github-actions bot requested a review from Dschoordsch May 22, 2024 18:31
@nickoferrall nickoferrall merged commit 413f5b6 into master May 23, 2024
6 checks passed
@nickoferrall nickoferrall deleted the feat/change-team-settings-upgrade-label branch May 23, 2024 09:53
@github-actions github-actions bot mentioned this pull request May 29, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants