feat: nav style refinements #9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
approved these changes
May 30, 2024
There was a problem hiding this comment.
Love it! Thanks for making those changes. I like the subtle vertical margin so that the active & hovered nav items don't touch.
The isOpen bit I commented out as I was going to update those styles in a later PR, but thanks for making those changes and including it now.
I'll merge this and crack on with the next part.
|
Thanks @nickoferrall ! I hope making a small PR doesn’t feel like stepping on toes but it’s hard to give a bunch of nits on pixel-level style details as feedback. This way it’s up to you if you want the changes. :) |
|
Oh no - not at all, I think that's the right way to do it! Thanks for making the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier than noting small paddings and margins, colors, etc. (which I would think is annoying), I made a few refinements to get closer to the Figma. If you like them feel free to merge them!
See the Loom