-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update org nav dashboard styles #9815
feat: update org nav dashboard styles #9815
Conversation
@nickoferrall here are numbered responses
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment with numbered responses! Once it’s ready I can take a refinement pass if needed so that I’m not backseat driving on pixel values.
Thanks for the responses! That all makes sense to me. For number 5, I had been working off the last design from here with the blue links, but I'll work from this design from now onwards |
I've pushed an update with:
|
Co-authored-by: Terry Acker <ackernaut@gmail.com>
Fix #9791
Loom demo: https://www.loom.com/share/cc181f0c48fc437880aa260bfce9ede1
Questions for Terry (outlined in the Loom above)
Are you happy with the active nav item styles? There's the vertical space and rounded edges. I think the vertical space is fine, but the edges probably shouldn't be rounded.
Should the organisation settings page sidebar be updated to look like the dash sidebar? So this section:
I lean towards updating it, but only once the dashboard nav is complete. For now, we could leave it as it is in production.
How do you feel about the "Team" tag? I didn't see this in designs. Happy to change the colour, of course.
Should we remove the links to org and settings here? I think we probably should as it's visible enough from the sidebar now
The parent PR won't be merged until the mobile styles and finished.