Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update org nav dashboard styles #9815

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

nickoferrall
Copy link
Contributor

Fix #9791

Loom demo: https://www.loom.com/share/cc181f0c48fc437880aa260bfce9ede1

Questions for Terry (outlined in the Loom above)

  1. Are you happy with the active nav item styles? There's the vertical space and rounded edges. I think the vertical space is fine, but the edges probably shouldn't be rounded.
    Screenshot 2024-06-03 at 16 58 57

  2. Should the organisation settings page sidebar be updated to look like the dash sidebar? So this section:
    Screenshot 2024-06-03 at 17 00 39

I lean towards updating it, but only once the dashboard nav is complete. For now, we could leave it as it is in production.

  1. How do you feel about the "Team" tag? I didn't see this in designs. Happy to change the colour, of course.
    Screenshot 2024-06-03 at 16 02 56

  2. Should we remove the links to org and settings here? I think we probably should as it's visible enough from the sidebar now
    Screenshot 2024-06-03 at 17 03 04

The parent PR won't be merged until the mobile styles and finished.

@github-actions github-actions bot added the size/m label Jun 3, 2024
@nickoferrall nickoferrall linked an issue Jun 4, 2024 that may be closed by this pull request
@ackernaut
Copy link
Member

@nickoferrall here are numbered responses

  1. Re: active team nav items, they should be rounded and the container with a border should have padding (see Figma). Note: ‘Settings & Members’ would also have a similar hover state, rounded and inset
  2. Re: org admin nav, we should update the org admin nav, too, since this is meant to be the same nav component. They should be rounded like the new main nav items (Meetings, History, etc.) and just need some padding. I’m happy to make a refinement PR if I need to.
  3. Re: tier tag colors, it seems the Team tag color we use is gold. See the mobile nav for an idea of the tag colors used. The layout looks good.
    Screenshot 2024-06-04 at 13 23 04.
  4. Re: team settings links, we can remove the org link. We need to keep the ‘Settings’ link as that’s the only way a Team Lead can delete their team. Once all functionality is moved to the Org Admin > Teams > Team view for a Team Lead we could consider removing both the Settings view and that link to it.
  5. Nit: (don’t use blue for dash nav items) all the nav items including Add a Team and Settings & Members will use the same icon and text styles for both default and hover/active (see Figma)

Copy link
Member

@ackernaut ackernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment with numbered responses! Once it’s ready I can take a refinement pass if needed so that I’m not backseat driving on pixel values.

@nickoferrall
Copy link
Contributor Author

Thanks for the responses! That all makes sense to me.

For number 5, I had been working off the last design from here with the blue links, but I'll work from this design from now onwards

@nickoferrall
Copy link
Contributor Author

I've pushed an update with:

  1. The active team nav bar
  2. I've created an issue for this: Admin Nav: org dash nav matches the dash nav #9826
  3. Tier tag updated
  4. I think we should probably wait until we can delete "Settings" too, otherwise it looks strange to me:
Screenshot 2024-06-05 at 12 57 11
  1. Swapped blue for slate

Co-authored-by: Terry Acker <ackernaut@gmail.com>
@github-actions github-actions bot added size/l and removed size/m labels Jun 14, 2024
@nickoferrall nickoferrall merged commit d0281df into feat/9790/nav-item-styles Jun 14, 2024
4 of 5 checks passed
@nickoferrall nickoferrall deleted the feat/9791/org-nav-section branch June 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Nav: org nav section
2 participants