fix: clicking scope link does not affect checkbox #9859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
requested changes
Jun 18, 2024
| const onClick = () => { | ||
|
|
||
| const handleClick = (e: React.MouseEvent) => { | ||
| e.stopPropagation() |
There was a problem hiding this comment.
-1 We have quite a few places where we stop event propagation in the app and to me it's never clear why it was put there, so it's impossible to remove or retest. Please add a comment.
Dschoordsch
approved these changes
Jun 24, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9858
Loom demo: https://www.loom.com/share/d47bb7b4bdce4ad49cc43cbbd7e38714
To test