fix: download pdf shows multiple pages #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
approved these changes
Jun 27, 2024
| @@ -18,6 +18,7 @@ const contentStyle = { | |||
| borderStyle: 'solid', | |||
| borderWidth: '1px', | |||
| boxSizing: 'content-box', | |||
| breakInside: 'avoid', | |||
There was a problem hiding this comment.
I snuck in this to avoid having a page break in a reflection card.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9862
In production, download to pdf just downloads the first page, rather than all pages. This is because
window.print()just shows the visible part of the web page in a SPA.In this PR, I'm opening a new window and rending the HTML as a static snapshot so that all of the content is visible.
The pdf shows "about:blank" at the bottom left of the page. I don't think this can be removed as the browser checks the URL. And there's some box shadow at the end of the summary in the PDF, but I think that's fine.
To test