Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow starting recurring meetings without GCal #9920

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Jul 2, 2024

Description

We were hiding the schedule button when no GCal integration was available on the instance. This is wrong in some cases when the dialog still allows to set up recurrence.
This PR also addresses a small title mismatch discovered by @garethaledavies which claimed recurring meetings when the option was not available.

Fixes #9913 #9777

Demo

https://www.loom.com/share/fda8dcea642949f698d37962fab216b6?sid=a2acbf99-6e62-4a0d-becb-f63a9da21b96

Testing scenarios

  • with GCal integration provider (after yarn build && yarn predeploy) test the schedule dialog in
    • poker and checkin show only the GCal options
    • retro and team prompt show GCal and recurrence options
  • remove the global GCal integration provider and test the schedule button again
    • poker and checkin do not show one
    • team prompt and retro only show the recurrence options

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch merged commit 3f2ca48 into master Jul 2, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the fix/9913/startRecurringMeetingsWithoutGCal branch July 2, 2024 14:49
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a meeting with recurrence requires GCal
2 participants