-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: parallelize codecheck #9983
Conversation
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Warning Rate limit exceeded@mattkrick has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 43 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe updates streamline code quality and type checking processes in GitHub Actions workflows. A new "Style Check" workflow is added, focusing on code quality checks like linting and styling. Meanwhile, the existing "test.yml" workflow is adjusted to focus solely on type checking. Additionally, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
codecheck currently takes 2 mins!
The bulk of that is prettier.
We could replace prettier + eslint with biome. It runs in 2 seconds!
Unfortunately, we require prettier-plugin-tailwindcss on the frontend.
Until biome offers support for tailwind class sorting (biomejs/biome#1274) we can't switch.
As an alternative, we can run prettier & eslint in parallel to the testing suite
Summary by CodeRabbit
codecheck
script inpackage.json
to removetypecheck
, simplifying the script.