Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce Azure DevOps scope #9999

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Jul 18, 2024

Description

Fixes #9944
We only need a subset of permissions, so let's only request those.

Demo

https://www.loom.com/share/d473bbd576f847418930aca0a7942fcb?sid=230028f7-52d8-4510-91c9-c96a46d9dd0b

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Test activities with the integration
  • push task
  • vote in poker

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Summary by CodeRabbit

  • New Features

    • Updated the Azure DevOps integration to enhance project and work write access.
  • Bug Fixes

    • Improved error tracking in OAuth2 authorization by adding error details to Sentry logs.

We only need a subset of permissions, so let's only request those.
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Walkthrough

The updates primarily adjust the Azure DevOps scope in the AzureDevOpsClientManager class to reduce the access permissions requested. Additionally, the authorizeOAuth2 function now logs OAuth2 errors to Sentry for better error tracking.

Changes

File Change Summary
packages/client/utils/AzureDevOpsClientManager.ts Modified the scope variable assignment to request more specific permissions, removing the broader .default scope and adding specific ones (vso.project and vso.work_write).
packages/server/integrations/helpers/authorizeOAuth2.ts Added Sentry error tracking by importing Sentry and logging OAuth2 errors as breadcrumbs to improve monitoring and debugging.

Assessment against linked issues

Objective Addressed Explanation
Reduce Azure DevOps scope (#9944)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/xs and removed size/s labels Jul 18, 2024
@Dschoordsch Dschoordsch merged commit e6a3c7d into master Jul 22, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the chore/9944/reduceADOScope branch July 22, 2024 08:27
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Azure DevOps scope
1 participant