error: question mark operator is useless here --> src/hot_reload/pattern_serde.rs:9:5 | 9 | / Ok(Pattern::new(&String::deserialize(de)?) 10 | | .map_err(serde::de::Error::custom)?) | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[deny(clippy::needless_question_mark)]` implied by `#[deny(clippy::all)]` help: try removing question mark and `Ok()` | 9 ~ Pattern::new(&String::deserialize(de)?) 10 + .map_err(serde::de::Error::custom) |

error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> src/model/lockfile/mod.rs:54:37 | 54 | pub fn get_lockfile(output_dir: &PathBuf) -> Result<Self> { | ^^^^^^^^ help: change this to: `&Path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[deny(clippy::ptr_arg)]` implied by `#[deny(clippy::all)]`

error: you are using an explicit closure for cloning elements --> src/model/servertoml/mod.rs:122:9 | 122 | / list.iter() 123 | | .filter(|v| { 124 | | is_proxy || v.game_versions.contains(mcver) 125 | | }) ... | 136 | | }) 137 | | .map(|v| v.clone()) | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[deny(clippy::map_clone)]` implied by `#[deny(clippy::all)]` help: consider calling the dedicated `cloned` method | 122 ~ list.iter() 123 + .filter(|v| { 124 + is_proxy || v.game_versions.contains(mcver) 125 + }) 126 + .filter(|v| { 127 + if let Some(n) = &loader { 128 + v.loaders.iter().any(|l| l == "datapack" || l == n) 129 + } else { 130 + if is_vanilla { 131 + v.loaders.contains(&"datapack".to_owned()) 132 + } else { 133 + true 134 + } 135 + } 136 + }).cloned() |

error: useless use of `format!` --> src/core/worlds.rs:80:29 | 80 | ).await.context(format!("Processing datapacks"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Processing datapacks".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of `format!` --> src/core/worlds.rs:68:45 | 68 | spinner.finish_with_message(format!("Unzipped world successfully")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unzipped world successfully".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[deny(clippy::useless_format)]` implied by `#[deny(clippy::all)]`

error: useless use of `vec!` --> src/core/bootstrap.rs:78:30 | 78 | let bootstrap_exts = vec![ | ______________________________^ 79 | | "properties", "txt", "yaml", "yml", "conf", "config", "toml", "json", "json5", "secret" 80 | | ]; | |_________^ help: you can use an array directly: `["properties", "txt", "yaml", "yml", "conf", "config", "toml", "json", "json5", "secret"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[deny(clippy::useless_vec)]` implied by `#[deny(clippy::all)]`

error: using `clone` on type `SystemTime` which implements the `Copy` trait --> src/core/bootstrap.rs:22:39 | 22 | .map(|e| (e.path.clone(), e.date.clone()))); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `e.date` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[deny(clippy::clone_on_copy)]` implied by `#[deny(clippy::all)]`

error: this `else { if .. }` block can be collapsed --> src/model/servertoml/mod.rs:129:20 | 129 | } else { | ____________________^ 130 | | if is_vanilla { 131 | | v.loaders.contains(&"datapack".to_owned()) 132 | | } else { 133 | | true 134 | | } 135 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if note: the lint level is defined here --> src/main.rs:1:9 | 1 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::collapsible_else_if)]` implied by `#[deny(clippy::all)]` help: collapse nested if block | 129 ~ } else if is_vanilla { 130 + v.loaders.contains(&"datapack".to_owned()) 131 + } else { 132 + true 133 + } |

warning: this match arm has an identical body to another arm --> src/hot_reload/mod.rs:43:33 | 43 | ... HotReloadAction::Restart => { | ^----------------------- | | | _______________________help: try merging the arm patterns: `HotReloadAction::Restart | HotReloadAction::Reload` | | 44 | | ... 45 | | ... } | |_______________________^ | = help: or try changing either arm body note: other arm here --> src/hot_reload/mod.rs:40:33 | 40 | / ... HotReloadAction::Reload => { 41 | | ... 42 | | ... } | |_______________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `#[warn(clippy::match_same_arms)]` implied by `#[warn(clippy::pedantic)]`

warning: unused `async` for function with no await statements --> src/hot_reload/mod.rs:17:5 | 17 | / pub async fn start(config: HotReloadConfig) -> Result<()> { 18 | | let server = Server::load().context("Failed to load server.toml")?; 19 | | let http_client = create_http_client()?; 20 | | ... | 64 | | Ok(()) 65 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: implicitly cloning a `PathBuf` by calling `to_owned` on its dereferenced type --> src/hot_reload/config.rs:31:18 | 31 | h.path = path.to_owned(); | ^^^^^^^^^^^^^^^ help: consider using: `path.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: empty String is being created manually --> src/sources/modrinth.rs:24:5 | 24 | String::from("") | ^^^^^^^^^^^^^^^^ help: consider using: `String::new()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new = note: `#[warn(clippy::manual_string_new)]` implied by `#[warn(clippy::pedantic)]`

warning: implicitly cloning a `Downloadable` by calling `to_owned` on its dereferenced type --> src/model/lockfile/mod.rs:119:58 | 119 | changes.mods.push(Change::Removed((filename, removed_mod.to_owned().clone()))); | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `removed_mod.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: implicitly cloning a `Downloadable` by calling `to_owned` on its dereferenced type --> src/model/lockfile/mod.rs:114:61 | 114 | changes.mods.push(Change::Added((String::new(), added_mod.to_owned().clone()))); | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `added_mod.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: usage of `FromIterator::from_iter` --> src/model/lockfile/mod.rs:110:60 | 110 | let lockfile_mods: HashMap<Downloadable, String> = HashMap::from_iter(self.mods | ____________________________________________________________^ 111 | | .iter().map(|(s, p)| (p.clone(), s.clone()))); | |_________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect help: use `.collect()` instead of `::from_iter()` | 110 ~ let lockfile_mods: HashMap<Downloadable, String> = self.mods 111 ~ .iter().map(|(s, p)| (p.clone(), s.clone())).collect::<HashMap<_, _>>(); |

warning: usage of `FromIterator::from_iter` --> src/model/lockfile/mod.rs:106:58 | 106 | let server_mods: HashMap<Downloadable, String> = HashMap::from_iter(server.mods | __________________________________________________________^ 107 | | .iter() 108 | | .map(|p| (p.clone(), String::new()))); | |_________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect help: use `.collect()` instead of `::from_iter()` | 106 ~ let server_mods: HashMap<Downloadable, String> = server.mods 107 + .iter() 108 + .map(|p| (p.clone(), String::new())).collect::<HashMap::from_iter(server.mods 109 + .iter() 110 ~ .map(|p| (p.clone(), String<_, _>>(); |

warning: implicitly cloning a `Downloadable` by calling `to_owned` on its dereferenced type --> src/model/lockfile/mod.rs:101:61 | 101 | changes.plugins.push(Change::Removed((filename, removed_plugin.to_owned().clone()))); | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `removed_plugin.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: implicitly cloning a `Downloadable` by calling `to_owned` on its dereferenced type --> src/model/lockfile/mod.rs:96:64 | 96 | changes.plugins.push(Change::Added((String::new(), added_plugin.to_owned().clone()))); | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `added_plugin.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: usage of `FromIterator::from_iter` --> src/model/lockfile/mod.rs:92:63 | 92 | let lockfile_plugins: HashMap<Downloadable, String> = HashMap::from_iter(self.plugins | _______________________________________________________________^ 93 | | .iter().map(|(s, p)| (p.clone(), s.clone()))); | |_________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect help: use `.collect()` instead of `::from_iter()` | 92 ~ let lockfile_plugins: HashMap<Downloadable, String> = self.plugins 93 ~ .iter().map(|(s, p)| (p.clone(), s.clone())).collect::<HashMap<_, _>>(); |

warning: usage of `FromIterator::from_iter` --> src/model/lockfile/mod.rs:88:61 | 88 | let server_plugins: HashMap<Downloadable, String> = HashMap::from_iter(server.plugins | _____________________________________________________________^ 89 | | .iter() 90 | | .map(|p| (p.clone(), String::new()))); | |_________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect help: use `.collect()` instead of `::from_iter()` | 88 ~ let server_plugins: HashMap<Downloadable, String> = server.plugins 89 + .iter() 90 + .map(|p| (p.clone(), String::new())).collect::<HashMap::from_iter(server.plugins 91 + .iter() 92 ~ .map(|p| (p.clone(), String<_, _>>(); |

warning: implicitly cloning a `PathBuf` by calling `to_owned` on its dereferenced type --> src/model/lockfile/mod.rs:68:19 | 68 | nw.path = path.to_owned(); | ^^^^^^^^^^^^^^^ help: consider using: `path.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

warning: redundant closure --> src/model/servertype/mod.rs:304:15 | 304 | }.map(|o| o.to_owned()) | ^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::borrow::ToOwned::to_owned` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls

warning: redundant closure --> src/model/servertoml/mod.rs:137:14 | 137 | .map(|v| v.clone()) | ^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::clone::Clone::clone` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls

warning: boolean to int conversion using if --> src/model/downloadable/import_url.rs:395:30 | 395 | .default(if url.path().starts_with("/job") { | ______________________________^ 396 | | 1 397 | | } else { 398 | | 0 399 | | }) | |_____________________^ help: replace with from: `usize::from(url.path().starts_with("/job"))` | = note: `url.path().starts_with("/job") as usize` or `url.path().starts_with("/job").into()` can also be valid options = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if = note: `#[warn(clippy::bool_to_int_with_if)]` implied by `#[warn(clippy::pedantic)]`

warning: unused `self` argument --> src/core/bootstrap.rs:75:34 | 75 | pub fn should_bootstrap_file(&self, path: &Path) -> bool { | ^^^^^ | = help: consider refactoring to an associated function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self = note: `#[warn(clippy::unused_self)]` implied by `#[warn(clippy::pedantic)]`

warning: usage of `FromIterator::from_iter` --> src/core/bootstrap.rs:21:62 | 21 | let lockfile_entries: HashMap<PathBuf, SystemTime> = HashMap::from_iter(self.lockfile.files.iter() | ______________________________________________________________^ 22 | | .map(|e| (e.path.clone(), e.date.clone()))); | |_______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect = note: `#[warn(clippy::from_iter_instead_of_collect)]` implied by `#[warn(clippy::pedantic)]` help: use `.collect()` instead of `::from_iter()` | 21 ~ let lockfile_entries: HashMap<PathBuf, SystemTime> = self.lockfile.files.iter() 22 ~ .map(|e| (e.path.clone(), e.date.clone())).collect::<HashMap<_, _>>(); |

warning: redundant closure --> src/core/addons.rs:32:18 | 32 | .map(|c| c.inner()) | ^^^^^^^^^^^^^ help: replace the closure with the method itself: `model::lockfile::Change::inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls = note: `#[warn(clippy::redundant_closure_for_method_calls)]` implied by `#[warn(clippy::pedantic)]`

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value. This can be done more directly by calling `map_or(<a>, <f>)` instead --> src/commands/world/unpack.rs:49:22 | 49 | let world_name = zipfile | ______________________^ 50 | | .file_name() 51 | | .map(|o| o.to_string_lossy().into_owned()) 52 | | .unwrap_or("world".to_owned()); | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or = note: `#[warn(clippy::map_unwrap_or)]` implied by `#[warn(clippy::pedantic)]` help: use `map_or(<a>, <f>)` instead | 51 - .map(|o| o.to_string_lossy().into_owned()) 51 + .map_or("world".to_owned(), |o| o.to_string_lossy().into_owned()); |

warning: case-sensitive file extension comparison --> src/commands/world/unpack.rs:23:44 | 23 | server.path.join("worlds").join(if s.ends_with(".zip") { s.clone() } else { format!("{s}.zip") }) | ^^^^^^^^^^^^^^^^^^^ | = help: consider using a case-insensitive comparison instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#case_sensitive_file_extension_comparisons = note: `#[warn(clippy::case_sensitive_file_extension_comparisons)]` implied by `#[warn(clippy::pedantic)]` help: use std::path::Path | 23 ~ server.path.join("worlds").join(if std::path::Path::new(s) 24 + .extension() 25 ~ .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) { s.clone() } else { format!("{s}.zip") }) |

warning: unused `async` for function with no await statements --> src/commands/world/unpack.rs:19:1 | 19 | / pub async fn run(matches: &ArgMatches) -> Result<()> { 20 | | let server = Server::load().context("Failed to load server.toml")?; 21 | | 22 | | let zipfile = if let Some(s) = matches.get_one::<String>("world") { ... | 65 | | Ok(()) 66 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async = note: `#[warn(clippy::unused_async)]` implied by `#[warn(clippy::pedantic)]`

warning: implicitly cloning a `String` by calling `to_owned` on its dereferenced type --> src/commands/add/modrinth.rs:23:9 | 23 | s.to_owned() | ^^^^^^^^^^^^ help: consider using: `s.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone = note: `#[warn(clippy::implicit_clone)]` implied by `#[warn(clippy::pedantic)]`

warning: this function has too many lines (110/100) --> src/commands/add/modrinth.rs:18:1 | 18 | / pub async fn run(matches: &ArgMatches) -> Result<()> { 19 | | let mut server = Server::load().context("Failed to load server.toml")?; 20 | | let http_client = create_http_client()?; 21 | | ... | 148 | | Ok(()) 149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines = note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`

warning: struct constructor field order is inconsistent with struct definition field order --> src/commands/build.rs:40:19 | 40 | let mut ctx = BuildContext { | ___________________^ 41 | | server, 42 | | http_client, 43 | | force, ... | 47 | | ..Default::default() 48 | | }; | |_____^ help: try: `BuildContext { server, http_client, output_dir, lockfile, force, skip_stages, ..Default::default() }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::inconsistent_struct_constructor)]` implied by `#[warn(clippy::pedantic)]`

warning: associated items `load_from`, `reload`, and `save` are never used --> src/hot_reload/config.rs:28:12 | 27 | impl HotReloadConfig { | -------------------- associated items in this implementation 28 | pub fn load_from(path: &PathBuf) -> Result<Self> { | ^^^^^^^^^ ... 35 | pub fn reload(&mut self) -> Result<()> { | ^^^^^^ ... 44 | pub fn save(&self) -> Result<()> { | ^^^^

warning: associated function `start` is never used --> src/hot_reload/mod.rs:17:18 | 16 | impl DevSession { | --------------- associated function in this implementation 17 | pub async fn start(config: HotReloadConfig) -> Result<()> { | ^^^^^

warning: associated items `load`, `load_from`, and `save` are never used --> src/model/network/mod.rs:34:12 | 33 | impl Network { | ------------ associated items in this implementation 34 | pub fn load() -> Result<Option<Self>> { | ^^^^ ... 53 | pub fn load_from(path: &PathBuf) -> Result<Self> { | ^^^^^^^^^ ... 63 | pub fn save(&self) -> Result<()> { | ^^^^ | = note: `#[warn(dead_code)]` on by default

warning: variable does not need to be mutable --> src/hot_reload/config.rs:38:13 | 38 | let mut h: Self = toml::from_str(&data)?; | ----^ | | | help: remove this `mut`

warning: unused import: `Watcher` --> src/hot_reload/mod.rs:2:14 | 2 | use notify::{Watcher, recommended_watcher, EventKind}; | ^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: variable does not need to be mutable --> src/hot_reload/mod.rs:28:13 | 28 | let mut config_watcher = recommended_watcher(move |e: std::result::Result<notify::Event, notify::Error>| { | ----^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `cmd` --> src/hot_reload/mod.rs:49:61 | 49 | ... HotReloadAction::RunCommand(cmd) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`

warning: unused variable: `pl` --> src/hot_reload/mod.rs:46:63 | 46 | ... HotReloadAction::ReloadPlugin(pl) => { | ^^ help: if this is intentional, prefix it with an underscore: `_pl`

warning: unused variable: `config_watcher` --> src/hot_reload/mod.rs:28:17 | 28 | let mut config_watcher = recommended_watcher(move |e: std::result::Result<notify::Event, notify::Error>| { | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_config_watcher`