refactor: bump cargo deps; some light code cleanup #146
Annotations
11 warnings
unused `async` for function with no await statements:
src/interop/hooks.rs#L27
warning: unused `async` for function with no await statements
--> src/interop/hooks.rs:27:5
|
27 | / pub async fn event(&self, event: HookEvent, _data: HashMap<String, String>) -> Result<()> {
28 | | for (name, hook) in &self.0.server.hooks {
29 | | if !hook.disabled && hook.when == event {
30 | | // execute?
... |
34 | | Ok(())
35 | | }
| |_____^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
|
unused `async` for function with no await statements:
src/commands/ws/mod.rs#L5
warning: unused `async` for function with no await statements
--> src/commands/ws/mod.rs:5:1
|
5 | / pub async fn run(_app: App) -> Result<()> {
6 | | Ok(())
7 | | }
| |_^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
= note: `-W clippy::unused-async` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`
|
method `resolve_name` is never used:
src/interop/hooks.rs#L10
warning: method `resolve_name` is never used
--> src/interop/hooks.rs:10:12
|
9 | impl<'a> HooksAPI<'a> {
| --------------------- method in this implementation
10 | pub fn resolve_name(&self, entry: &str) -> String {
| ^^^^^^^^^^^^
|
function `run` is never used:
src/commands/ws/mod.rs#L5
warning: function `run` is never used
--> src/commands/ws/mod.rs:5:14
|
5 | pub async fn run(_app: App) -> Result<()> {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused variable: `name`:
src/interop/hooks.rs#L28
warning: unused variable: `name`
--> src/interop/hooks.rs:28:14
|
28 | for (name, hook) in &self.0.server.hooks {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
|
= note: `#[warn(unused_variables)]` on by default
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
unused `async` for function with no await statements:
src/interop/hooks.rs#L27
warning: unused `async` for function with no await statements
--> src/interop/hooks.rs:27:5
|
27 | / pub async fn event(&self, event: HookEvent, _data: HashMap<String, String>) -> Result<()> {
28 | | for (name, hook) in &self.0.server.hooks {
29 | | if !hook.disabled && hook.when == event {
30 | | // execute?
... |
34 | | Ok(())
35 | | }
| |_____^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
|
unused `async` for function with no await statements:
src/commands/ws/mod.rs#L5
warning: unused `async` for function with no await statements
--> src/commands/ws/mod.rs:5:1
|
5 | / pub async fn run(_app: App) -> Result<()> {
6 | | Ok(())
7 | | }
| |_^
|
= help: consider removing the `async` from this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
= note: `-W clippy::unused-async` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`
|
method `resolve_name` is never used:
src/interop/hooks.rs#L10
warning: method `resolve_name` is never used
--> src/interop/hooks.rs:10:12
|
9 | impl<'a> HooksAPI<'a> {
| --------------------- method in this implementation
10 | pub fn resolve_name(&self, entry: &str) -> String {
| ^^^^^^^^^^^^
|
function `run` is never used:
src/commands/ws/mod.rs#L5
warning: function `run` is never used
--> src/commands/ws/mod.rs:5:14
|
5 | pub async fn run(_app: App) -> Result<()> {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused variable: `name`:
src/interop/hooks.rs#L28
warning: unused variable: `name`
--> src/interop/hooks.rs:28:14
|
28 | for (name, hook) in &self.0.server.hooks {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
|
= note: `#[warn(unused_variables)]` on by default
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
mcman-ubuntu-latest
Expired
|
8.55 MB |
|
mcman-windows-latest
Expired
|
9.97 MB |
|