Skip to content

[refactor,style]: cleanup more code + cargo fmt #182

[refactor,style]: cleanup more code + cargo fmt

[refactor,style]: cleanup more code + cargo fmt #182

Triggered via push February 2, 2024 09:40
Status Failure
Total duration 29s
Artifacts

build.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 4 warnings
mismatched types: src/app/from_string.rs#L168
error[E0308]: mismatched types --> src/app/from_string.rs:168:25 | 166 | let version = self.select( | ------ arguments to this method are incorrect 167 | "Select a version", 168 | / versions 169 | | .iter() 170 | | .map(|v| { 171 | | SelectItem( ... | 179 | | }) 180 | | .collect::<Vec<_>>(), | |________________________________________________^ expected `&[SelectItem<_>]`, found `Vec<SelectItem<CurseRinthVersion>>` | = note: expected reference `&[util::SelectItem<_>]` found struct `std::vec::Vec<util::SelectItem<sources::curserinth::CurseRinthVersion>>` note: method defined here --> src/app/feedback.rs:215:12 | 215 | pub fn select<T: Clone>(&self, prompt: &str, items: &[SelectItem<T>]) -> Result<T> { | ^^^^^^ ----------------------- help: consider borrowing here | 168 | &versions | +
mismatched types: src/app/from_string.rs#L129
error[E0308]: mismatched types --> src/app/from_string.rs:129:25 | 127 | let version = self.select( | ------ arguments to this method are incorrect 128 | "Select a version", 129 | / versions 130 | | .iter() 131 | | .map(|v| { 132 | | SelectItem( ... | 140 | | }) 141 | | .collect::<Vec<_>>(), | |________________________________________________^ expected `&[SelectItem<_>]`, found `Vec<SelectItem<CurseRinthVersion>>` | = note: expected reference `&[util::SelectItem<_>]` found struct `std::vec::Vec<util::SelectItem<sources::curserinth::CurseRinthVersion>>` note: method defined here --> src/app/feedback.rs:215:12 | 215 | pub fn select<T: Clone>(&self, prompt: &str, items: &[SelectItem<T>]) -> Result<T> { | ^^^^^^ ----------------------- help: consider borrowing here | 129 | &versions | +
mismatched types: src/app/from_string.rs#L93
error[E0308]: mismatched types --> src/app/from_string.rs:93:25 | 91 | let version = self.select( | ------ arguments to this method are incorrect 92 | "Select a version", 93 | / versions 94 | | .iter() 95 | | .map(|v| { 96 | | SelectItem( ... | 104 | | }) 105 | | .collect::<Vec<_>>(), | |________________________________________________^ expected `&[SelectItem<_>]`, found `Vec<SelectItem<ModrinthVersion>>` | = note: expected reference `&[util::SelectItem<_>]` found struct `std::vec::Vec<util::SelectItem<sources::modrinth::ModrinthVersion>>` note: method defined here --> src/app/feedback.rs:215:12 | 215 | pub fn select<T: Clone>(&self, prompt: &str, items: &[SelectItem<T>]) -> Result<T> { | ^^^^^^ ----------------------- help: consider borrowing here | 93 | &versions | +
build (ubuntu-latest)
Process completed with exit code 101.
clippy
Clippy had exited with the 101 exit code
build (windows-latest)
The operation was canceled.
build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.