Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleeping for 584542100000 years on rate limit #36

Closed
ClusterConsultant opened this issue Dec 15, 2023 · 2 comments
Closed

Sleeping for 584542100000 years on rate limit #36

ClusterConsultant opened this issue Dec 15, 2023 · 2 comments

Comments

@ClusterConsultant
Copy link

When getting rate limited, mcman seems to pick a very very large number of seconds to sleep. While I can work around this by just using a token, it seems this is not ideal behavior.
image

@TheAlan404
Copy link
Contributor

TheAlan404 commented Dec 15, 2023

wow um. that number is decided upon the X-Ratelimit-Reset header value sent back by modrinth, ill take a look at it

im gonna take a guess and say its probably that github returns remaining time unlike github which returns a unix timestamp

@TheAlan404
Copy link
Contributor

X-Ratelimit-Reset: the time in seconds until the ratelimit window resets

yep, should be easy to fix

TheAlan404 added a commit that referenced this issue Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants