Adds various ventcrawl QoL changes #14432

warior4356 · 2020-09-25T06:19:32Z

This Fixes #11813

What Does This PR Do

This PR makes a few changes to improve the experience of someone ventcrawling

When you change pipenets, or if a pipenet is updated your visual pipemap will update rather than remaining static. (See gif below)
You can enter any pipe if it has an open end.
Leaving ventcrawl via pipes now has a 3 second delay to prevent antags from leaving by mistake.
Maintenance drones have the ability to enter and exit welded vents after a 15-second interact.
You can now enter passive vents.

Why It's Good For The Game

Having the pipes be different than what you see while vent crawling is annoying and can result in death.
Broken pipes can be quite an inconvenience to an antag.
Preventing antags from accidentally leaving vent crawl into a room with a hostile or worse, via a broken pipe into an open area can easily result in death. Without change 2 the later case would leave them quite stranded.
Maintenance drones should be able to move freely even in terror spider rounds. They also shouldn't have any reason to unweld a vent in a terror round.
Felt like an oversight.

Images of changes

Changelog

🆑
add: Added the ability to vent crawl into open pipes.
add: Added a 3 seconds delay to leaving ventcrawl via pipes.
add: Added the ability to enter passive vents.
add: Added the ability for maintenance drones to enter welded vents after a delay.
tweak: Ventcrawl overlay now updates when changing pipenets and when a pipenet is edited.
/:cl:

hal9000PR · 2020-09-25T06:38:56Z

Does this mean that you can see the tubes if you go from the station loop to the security loop?

TDSSS · 2020-09-25T07:20:51Z

While the delay on leaving via broken pipes is good, it sounds like a lot when trying to just jump out of a vent to ambush someone. Can you make the timer shorter for vents than broken pipes?

warior4356 · 2020-09-25T08:32:40Z

While the delay on leaving via broken pipes is good, it sounds like a lot when trying to just jump out of a vent to ambush someone. Can you make the timer shorter for vents than broken pipes?

I can, do you have values in mind? Also, the timer is only visible to the person leaving the vent, it's not like they get a warning.

Does this mean that you can see the tubes if you go from the station loop to the security loop?

Yes. Yes it does. Changing pipe nets as you can see in the gif will re render it.

code/ATMOSPHERICS/atmospherics.dm

BakKeener · 2020-09-25T10:32:07Z

From what this PR offers, I am mostly up for it except for one thing.

The 3 second timer to leave a vent. There is a lot of antags who uses vents for combat purposes. This makes ambushes harder, and gives the crew a 3 second safety net knowing they can weld it without them popping out. If it was changed to give a timer for pipes, that would actually be an advantage as it would prevent people from accidentally popping out of those as they are the main culprits of tricking people out of vents.

Other than that one thing, All the other additions look great.

code/ATMOSPHERICS/atmospherics.dm

code/modules/mob/living/carbon/carbon.dm

Kyep

I'm fine with this, but I do have one request:
make the delay on exiting a pipe onto a turf only apply if the pipe is disconnected.
IE: if you exit a pipe via an open vent, that should be instant, but if you exit a pipe that's broken there should be a delay on that (with progress bar, to prevent you accidentally leaving a broken pipe, but not delay you from intentionally exiting via a vent).

warior4356 · 2020-09-25T21:20:46Z

A few changes along with the style fixes.
All drones can bypass welded vents and the timer is 10 seconds.
The timer is removed from leaving vents, it's only on pipes.

Carthusia · 2020-09-26T00:37:21Z

Perhaps make the vent exit timer a toggle in the top right hand corner?

It starts off, but if someone wishes they can toggle it on?

Kyep · 2020-09-27T04:46:59Z

Requesting you add Fixes #11813 to the PR description so that if this is merged, that issue will be closed.

warior4356 · 2020-09-27T22:13:45Z

Requesting you add Fixes #11813 to the PR description so that if this is merged, that issue will be closed.

Already fixed. That was point 1 of the PR @Kyep

TDSSS · 2020-09-27T23:45:44Z

Requesting you add Fixes #11813 to the PR description so that if this is merged, that issue will be closed.

Already fixed. That was point 1 of the PR @Kyep

No, the exact words 'Fixes #11813' need to appear in the PR's description so that github can automatically close the issue #11813 when it gets merged.

warior4356 · 2020-09-28T00:28:51Z

Sorry for the misunderstanding, the description has been updated.

boniondev · 2020-10-21T13:32:28Z

I like this PR, i finally can still enter vents during terror rounds as a drone. Small curiosity though. When a drone alt clicks a welded vent, does it display a certain message in the chat or do others just see a drone vibing next to a vent?

farie82 · 2021-01-22T08:50:42Z

code/modules/mob/living/carbon/carbon.dm

+				"<span class='notice'>You climb into the ventilation system. With a resounding snap the [entrance_found] is fastened back in place.</span>")
+			else
+				visible_message("<span class='boldnotice'>[src] scrambles into the ventilation ducts!</span>", "<span class='notice'>You climb into the ventilation system.</span>")
+			loc = entrance_found


Suggested change

loc = entrance_found

forceMove(entrance_found)

Will make sure other logic won't break

I tried this. It completely breaks ventcrawling, by making all nonpipes solid black sprites.

warior4356 · 2021-01-22T10:39:08Z

@SteelSlayer I am unable to replicate your T-ray issue or the runtime. I tried to do what was in your screenshot to no avail.

AffectedArc07

First pass, split for reasons

AffectedArc07 · 2021-01-22T19:04:11Z

code/ATMOSPHERICS/atmospherics.dm

-			user.forceMove(src.loc)
-			user.visible_message("You hear something squeezing through the pipes.", "You climb out the ventilation system.")
-	user.canmove = 0
+			if(do_after(user, 30, target = src))


Sources tell me target=src may be a problem and may not work well with people in vents

Target is just for the location of the progress bar and is only visible to the user. It worked fine in testing. Is there any interaction you are concerned about?

AffectedArc07 · 2021-01-22T19:04:29Z

code/ATMOSPHERICS/atmospherics.dm


 /obj/machinery/atmospherics/AltClick(var/mob/living/L)
-	if(is_type_in_list(src, GLOB.ventcrawl_machinery))
+	if(is_type_in_list(src, GLOB.ventcrawl_machinery) || check_open())


Are you sure this is meant to be ||?

Yes, because vent crawl machinery is the list of vents, scrubbers, and passive vents. Check open on the other hand is a function that checks if the chosen atmospherics machinery has a potential connection that isn't currently filled, for example, a T junction with an open side.

TLDR: This OR lets you enter open pipes.

code/ATMOSPHERICS/components/unary_devices/vent_pump.dm

code/ATMOSPHERICS/components/unary_devices/vent_scrubber.dm

AffectedArc07 · 2021-01-22T19:08:15Z

code/modules/mob/living/carbon/carbon.dm

-			if(!do_after(src, 45, target = src))
+	if(entrance_found)
+		var/datum/pipeline/P = entrance_found.returnPipenet()
+		if(P && (length(P.members) || P.other_atmosmch))


Doesnt this make it so you cant climb into single device pipenets? If so you need to document this change

I went back and checked, you are still able to climb into single device pipe nets.

AffectedArc07

Second batch

code/ATMOSPHERICS/atmospherics.dm

code/modules/mob/living/carbon/carbon.dm

AffectedArc07 · 2021-01-22T19:12:39Z

code/modules/mob/living/carbon/carbon.dm

-	else
-		to_chat(src, "<span class='warning'>This ventilation duct is not connected to anything!</span>")
+			show_ventcrawl(entrance_found)
+			loc = entrance_found // This can not be a forcemove. It will break the ventcrawl UI


Can you figure out why forceMove() breaks this? Force setting the loc var without other sanity checks is bad practice

I can try, though this kinda falls into legacy code that I don't really understand why territory. I was just adding a comment for the sake of others trying to fix this in the future. It wasn't code I added.

code/ATMOSPHERICS/atmospherics.dm

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

…into crawl-tweaks

code/modules/atmospherics/machinery/atmospherics.dm

dearmochi · 2021-03-04T11:23:26Z

code/modules/atmospherics/machinery/atmospherics.dm

-			user.remove_ventcrawl()
-			user.forceMove(target_move.loc) //handles entering and so on
-			user.visible_message("You hear something squeezing through the ducts.", "You climb out the ventilation system.")
+		if(is_type_in_list(target_move, GLOB.ventcrawl_machinery))


Not your fault, but yikes, this should really use a typecache instead of constantly looping through a list.

code/modules/mob/living/carbon/carbon.dm

dearmochi · 2021-03-04T11:28:13Z

code/modules/mob/living/carbon/carbon.dm

-			visible_message("<b>[src] scrambles into the ventilation ducts!</b>", "You climb into the ventilation system.")
-			src.loc = vent_found
-			add_ventcrawl(vent_found)
+				if(failed)


Not sure failed is necessary here, since you're returning at the first chance you get.

Yea, there used to be multiple things that caused failed.

dearmochi · 2021-03-04T11:29:55Z

code/modules/mob/living/carbon/carbon.dm


 /mob/living/proc/remove_ventcrawl()
+	GLOB.ventcrawlers.Remove(src)


Does remove_ventcrawl get called when the mob is destroyed? If not, there might be a null value in the ventcrawlers list.

Basically yes. Update ventcrawl gets called every time a pipenet is updated, which will remove them. I added it to destroy to be sure.

code/modules/mob/living/carbon/carbon.dm

code/modules/mob/living/silicon/robot/drone/drone.dm

Co-authored-by: dearmochi <shenesis@gmail.com>

Fixes done

54c6d1f

Fixes linter issue

ee3792a

AffectedArc07 added the Tweak This PR tweaks something ingame label Sep 25, 2020

AffectedArc07 reviewed Sep 25, 2020

View reviewed changes

code/ATMOSPHERICS/atmospherics.dm Outdated Show resolved Hide resolved

AffectedArc07 requested changes Sep 25, 2020

View reviewed changes

code/ATMOSPHERICS/atmospherics.dm Outdated Show resolved Hide resolved

SteelSlayer reviewed Sep 25, 2020

View reviewed changes

Kyep approved these changes Sep 25, 2020

View reviewed changes

warior4356 added 3 commits September 25, 2020 13:06

Removed delay on exiting vents

cc70211

Emagged drones can now bypass welded vents

24d3d30

Fixed 1 vs true

0255b2a

github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 25, 2020

warior4356 added 3 commits September 25, 2020 13:18

Misc coding standards

a3f0b1a

Span tags

b770285

reducee drone welding bypass to 10 seconds

12707f3

warior4356 added 2 commits September 25, 2020 14:26

Merge branch 'master' into crawl-tweaks

d4dc55a

Readded bug fix post merge conflict

5f7a725

github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 25, 2020

warior4356 requested a review from AffectedArc07 September 25, 2020 22:40

moxian mentioned this pull request Nov 16, 2020

Ventcrawlers can get perma-stuck in server room #14910

Closed

farie82 reviewed Jan 22, 2021

View reviewed changes

Makes drone stuff OOP. Lowers overhead on pipe creation and destruction.

073e751

AffectedArc07 requested changes Jan 22, 2021

View reviewed changes

Ryal and others added 6 commits January 22, 2021 14:41

Adds inline conditionals AA requested

af08c70

Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>

Cleans up duplicated code

678b62c

Merge branch 'crawl-tweaks' of https://github.com/warior4356/Paradise …

1e84fbf

…into crawl-tweaks

Removes unneeded check

8bbfc52

Makes leaving a pipe put you on the turf rather than loc

1eb613d

removes typing

9b42afb

github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 24, 2021

Merge branch 'master' into crawl-tweaks

6ab13ed

github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 26, 2021

github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 16, 2021

Merge branch 'master' into crawl-tweaks

a847bc4

github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 19, 2021

warior4356 requested a review from AffectedArc07 February 24, 2021 04:00

github-actions bot added the Merge Conflict This PR is merge conflicted label Mar 3, 2021

Merge branch 'master' into crawl-tweaks

7bf7db4

dearmochi reviewed Mar 4, 2021

View reviewed changes

github-actions bot removed the Merge Conflict This PR is merge conflicted label Mar 4, 2021

Ryal and others added 3 commits March 9, 2021 13:21

Apply suggestions from code review

17d5f89

Co-authored-by: dearmochi <shenesis@gmail.com>

Fixes possible null value issue and formatting

7b25c58

Formatting tweak

5d66d53

github-actions bot added the Merge Conflict This PR is merge conflicted label Mar 11, 2021

warior4356 added 2 commits March 12, 2021 19:06

Merge branch 'master' into crawl-tweaks

085095a

Removes unneeded var

37b1af3

github-actions bot removed the Merge Conflict This PR is merge conflicted label Mar 13, 2021

AffectedArc07 closed this Aug 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds various ventcrawl QoL changes #14432

Adds various ventcrawl QoL changes #14432

warior4356 commented Sep 25, 2020 •

edited

Loading

hal9000PR commented Sep 25, 2020

TDSSS commented Sep 25, 2020

warior4356 commented Sep 25, 2020

BakKeener commented Sep 25, 2020

Kyep left a comment

warior4356 commented Sep 25, 2020

Carthusia commented Sep 26, 2020

Kyep commented Sep 27, 2020 •

edited

Loading

warior4356 commented Sep 27, 2020

TDSSS commented Sep 27, 2020

warior4356 commented Sep 28, 2020

boniondev commented Oct 21, 2020

farie82 Jan 22, 2021

warior4356 Jan 22, 2021

warior4356 commented Jan 22, 2021

AffectedArc07 left a comment

AffectedArc07 Jan 22, 2021

warior4356 Jan 22, 2021

AffectedArc07 Jan 22, 2021

warior4356 Jan 22, 2021

AffectedArc07 Jan 22, 2021

warior4356 Jan 22, 2021

AffectedArc07 left a comment

AffectedArc07 Jan 22, 2021

warior4356 Jan 22, 2021

dearmochi Mar 4, 2021

dearmochi Mar 4, 2021

warior4356 Mar 9, 2021

dearmochi Mar 4, 2021

warior4356 Mar 9, 2021


		/mob/living/proc/remove_ventcrawl()
		GLOB.ventcrawlers.Remove(src)

Adds various ventcrawl QoL changes #14432

Adds various ventcrawl QoL changes #14432

Conversation

warior4356 commented Sep 25, 2020 • edited Loading

What Does This PR Do

Why It's Good For The Game

Images of changes

Changelog

hal9000PR commented Sep 25, 2020

TDSSS commented Sep 25, 2020

warior4356 commented Sep 25, 2020

BakKeener commented Sep 25, 2020

Kyep left a comment

Choose a reason for hiding this comment

warior4356 commented Sep 25, 2020

Carthusia commented Sep 26, 2020

Kyep commented Sep 27, 2020 • edited Loading

warior4356 commented Sep 27, 2020

TDSSS commented Sep 27, 2020

warior4356 commented Sep 28, 2020

boniondev commented Oct 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

warior4356 commented Jan 22, 2021

AffectedArc07 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AffectedArc07 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

warior4356 commented Sep 25, 2020 •

edited

Loading

Kyep commented Sep 27, 2020 •

edited

Loading