Big Fat Emission PR

[kugamo]

What Does This PR Do

This PR adds emission effects to a plethora of objects in the game.

• Light tubes, and light bulbs. They were being shaded like the rest of the objects in the game and as a result, looked especially weird in low light conditions. I added states for normal and nightshift lighting settings, so they look appropriately luminescent according to their setting.
• Airlocks. This was tedious. All airlocks' closed/closing/opening/locked/deny/sparking states are now emissive. I believe it looks really good in maint and low light, now their buttons glow! Really adds to the visual flair of the game.
• Fire alarms. They were emissive when alarming, but I also added it for their default state. I also altered the light bar that shows the alert level for delta/epsilon (before they shared sprites with gamma [red/yellow] ) making delta [white/yellow] and epsilon full white. Also changed how the fire-alarm-effect works on lights, now they go into emergency mode. (looks alot better, otherwise the emissive effects layered weirdly on the red-toned lights.)
• Air alarms. Now the small square is emissive, for all alert levels.
• Intercoms.
• Newscasters. Also fixed the wanted icon alert overlay that was in the icon folder but not implamented for some reason.
• Entertainment Screens.
• AI displays. Also refactored their code a bit, putting everything in update_icon() (it was messy, sorry for bloat)
• Status displays.
• Request Consoles.
• ATMs.
• Light switches.
• APCs.
• Holoprojectors.
• Mounted Flashes.
• Teleporter hub and station.
• Rechargers. Wall mounted and the desktop one.
• Bar sign.
• Mr chang's and Barber signs.
• Morgue trays.
• Disposal Bins.
• Keycard Authenticators
• Nuclear Bomb
• Dance Machine
• Crematorium

SPECIAL NOTE: I had to add light sources to all these devices while their emissive effects are displaying so that byond didnt cull them from the clients screen when the atoms are in complete darkness. The light is so weak it doesnt illuminate anything, and only serves this purpose. THESE LIGHT SOURCES DO DISPLAY THE TURF AND 4 SURROUNDING TURFS TO THE RIGHT CLICK MENU, so there are balance concerns with the PR as is. I will attempt to find a solution to this in the following days

graph

This is the result of the testmerge. I had concerns about performance, but after viewing this graph I judge its impact is minimal. (not enough for me to significantly rework or close the PR at least) I'd direct inquiry about it at AA, but god knows he has enough on his plate already.

Why It's Good For The Game

Alot of stuff's icons had lights and bobbles that look like they should be illuminated but got shaded into darkness with everything else (even light sources like bulbs and tubes to some degree). You should be able to see everything like this in a room in complete darkness, due to how our lighting works they would get completely darkened or disappeared completely. Now you can see them, and it looks great! Green is during TM, pink round before.

Images of changes

Gifs and videos probably aren't the best way to experience the benefits of this PR, I encourage reviewers to download the branch and playtest it. Kind of an ask, but I think its warranted.

BEFORE:

dreamseeker_JueVRUQgE4.mp4

AFTER

dreamseeker_kPBkWmpn7R.mp4

---

BEFORE:

AFTER:

---

BEFORE:

AFTER:

---

BEFORE:

AFTER:

---

BEFORE:

AFTER:

---

BEFORE:

AFTER:

Changelog

🆑
imageadd: Added emissive effects to lights, airlocks, and a large amount of other station devices.
/:cl:

[AffectedArc07]

Im going to testmerge this and keep an eye on the maptick usage, as I fear this could add a lot to it.

[AffectedArc07]

I have a CSV of the data that ill run more numbers on

[farie82]

I saw a lot of set_light(X, 0.1). Might it be an idea to make a define for the 0.1? Like LOW_LIGHT_POWER or whatever.
Also, be sure to go over each case of update_icon where you do it twice in a row. You can and should combine the flags together.

[farie82]

Few last small things

[farie82]

Nice job on the PR. It's really neat looking