Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks CNS Implant + Emagged Upgraded Cybernetic Heart #18202

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

ItsMarmite
Copy link
Contributor

@ItsMarmite ItsMarmite commented Jul 3, 2022

What Does This PR Do

  • Changes all instances of anti_stun to anti_stam in the code in relation to the CNS implant.

  • Reworks the CNS implant to protect against large bursts of stamina damage.

  • Reworks the emagged upgraded cybernetic heart to cause the user to regenerate stamina passively.

  • Removes emagged upgraded cybernetic heart's ability to negate drowsiness and sleeping.

  • CNS will now cause a 'weaken' instead of a 'stun' to give a better visual effect of the weakness if the user is subject to an EMP. Duration has not been changed.

Why It's Good For The Game

With the move towards stamina based combat, CNS and Emagged Heart have been left behind, not really fitting in the current direction combat is moving. As a result, this PR reworks both to fit this new direction.

Changelog

🆑
tweak: Reworked CNS Implant and Emagged Upgraded Cybernetic Heart to fit within new direction of stamina combat.
/:cl:

Changes all instances of anti_stun to anti_stam in the code in relation to the CNS implant. Reworks the CNS implant to protect against large bursts of stamina damage. Reworks the emagged upgraded cybernetic heart to cause the user to regen stamina passively. Disabler shots can now cause the emagged upgraded cybernetic heart to fail, causing heart attacks. Removes emagged upgraded cyberheart's ability to negate drowsiness and sleeping. The upgraded cybernetic heart now makes a passive heartbeat noise, much like the cursed heart.
@SpringSkipper
Copy link
Contributor

DO NOT nerf emagged cyberheart like that. It's already extremely niche and makes ions one-shot you, basically turning you into an IPC traitor. Disablers causing heart attacks ruins it entirely.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jul 3, 2022
@Inadvizable
Copy link
Contributor

Inadvizable commented Jul 3, 2022

DO NOT nerf emagged cyberheart like that. It's already extremely niche and makes ions one-shot you, basically turning you into an IPC traitor. Disablers causing heart attacks ruins it entirely.

This is a buff, it makes the heart insanely good at removing stamina. We're talking 20 stamina instead of 2 here, an entire order of magnitude better. It is actually pretty much useless currently now that we've moved mostly to stamina combat.

@AffectedArc07 AffectedArc07 added Balance This PR will modify how effective something is or isnt Project Progression labels Jul 3, 2022
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jul 3, 2022
Lowers chance of heart attack. Removes audible heartbeat.
@SpringSkipper
Copy link
Contributor

I'm looking at the "people can hear heart" and "heart attack from disablers" nerfs in particular.

Keep in mind that to get one you need to
-research until you can get a heart, then print one
-emag your heart
-get someone else to put the heart in

and then you already instantly die to EMP and sometimes stun batons and door zaps. The moment you go down from disabler fire they're going to start bapping you with batons anyways. Why is that necessary?

and then you get outed to anyone standing next to you?

@Qwertytoforty
Copy link
Contributor

I'm looking at the "people can hear heart" and "heart attack from disablers" nerfs in particular.

Keep in mind that to get one you need to -research until you can get a heart, then print one -emag your heart -get someone else to put the heart in

and then you already instantly die to EMP and sometimes stun batons and door zaps. The moment you go down from disabler fire they're going to start bapping you with batons anyways. Why is that necessary?

and then you get outed to anyone standing next to you?

Noise was removed. PR description was not updated.

@RagingLemons1
Copy link

as others have said, everything looks fine except the nerf of the cyber heart. It already has a way to kill you with ions, with the hassle of getting one installed, you don't need to and shouldn't give sec disablers a heart attack function.

no problem with the heart noise though, if you have one of these it seems assumed that you're going loud.

@procdrone
Copy link
Contributor

Agreeing with others.

considering that every single officer is going to have a disabler and will 99% use it on people they chase, that particular malus for emmaged heart does seem excessive.

@hal9000PR
Copy link
Member

hal9000PR commented Jul 4, 2022

Every officer also has a baton, which currently does the same thing.
Every officer used to have a taser, which did the same thing.
The item was outdated and didnt account for stamina. This is only updating it for stamina.

@ItsMarmite
Copy link
Contributor Author

Heart attack chance removed on request.

@ItsMarmite ItsMarmite requested a review from Fox-McCloud July 5, 2022 15:35
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jul 6, 2022
ItsMarmite and others added 2 commits July 9, 2022 13:16
Sure

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Why not?

Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
Copy link
Member

@SteelSlayer SteelSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Hal's review within 7 days.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jul 19, 2022
@hal9000PR hal9000PR merged commit 6d1876a into ParadiseSS13:master Jul 19, 2022
github-actions bot added a commit that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt
Projects
None yet
Development

Successfully merging this pull request may close these issues.