Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the stun from flashes and gives them a cooldown #18275

Merged
merged 5 commits into from
Jul 10, 2022

Conversation

Inadvizable
Copy link
Contributor

What Does This PR Do

The stun has been removed from the targeted flash, although it does still disarm the victim. Flashes have been given a cooldown of 5 seconds, except for the arm-mounted photon projector which already had a cooldown of 2 seconds, and this has been kept. Additionally, I have removed "your the" from the chat messages and a bit of duplicate code. Part of the stun removal project by @hal9000PR.

Why It's Good For The Game

Instant stuns bad, we've been over this. The flash used to stun for 1 cycle, which was 0-2 seconds, presumably to remove items from your hands. This has since changed, and with it being guaranteed 2 seconds... it's a little silly. Additionally, flashes can be spammed until RNG decides to mercifully burn them out - with just a little luck, a roundstart item can be used to cause severe eye damage to everyone else on screen, friend or foe, spamming attack logs... and of course, it is ubiquitous enough that it is easy to stock up on them. This can happen accidentally too, when people (read: CMOs) panic a little. Removing this capability prevents such things from happening.

Changelog

🆑
tweak: Flashes have been given a 5 second cooldown and no longer stun, but still disarm people. Photon projector implants still have a 2 second cooldown.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jul 8, 2022
@AffectedArc07 AffectedArc07 added the Balance This PR will modify how effective something is or isnt label Jul 8, 2022
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jul 8, 2022
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jul 9, 2022
@Bm0n
Copy link
Contributor

Bm0n commented Jul 10, 2022

Ehhh it's probably better to instead port TGs directional based flash stuns instead. This seems too severe for a weapon that has a hard counter to it in the form of flash protection and makes it nearly useless as a weapon against humans

@hal9000PR
Copy link
Member

Ehhh it's probably better to instead port TGs directional based flash stuns instead. This seems too severe for a weapon that has a hard counter to it in the form of flash protection and makes it nearly useless as a weapon against humans

I'm not sold on TGs flashes. It doesnt seem very fun for an antags target to get walked up to and instantly stam critted. Especially from a small item. I don't want people looking at eachother to be a source of anxiety because you can instantly get stunned from it.

And the idea of these stun conversions isn't just to port all of TGs stuff blindly.

@Bm0n
Copy link
Contributor

Bm0n commented Jul 10, 2022

Ehhh it's probably better to instead port TGs directional based flash stuns instead. This seems too severe for a weapon that has a hard counter to it in the form of flash protection and makes it nearly useless as a weapon against humans

I'm not sold on TGs flashes. It doesnt seem very fun for an antags target to get walked up to and instantly stam critted. Especially from a small item. I don't want people looking at eachother to be a source of anxiety because you can instantly get stunned from it.

And the idea of these stun conversions isn't just to port all of TGs stuff blindly.

Tg flashes only really work as a defense weapon. If you have any common sense on TG you turn away as soon as someone pulls a flash since they can't stun you if you're not facing them or prepare by stealing sunglasses. This pr makes them a little too weak imo

Copy link
Member

@hal9000PR hal9000PR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the admin log spam would have been enough justification.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jul 10, 2022
@hal9000PR hal9000PR merged commit a02c0cb into ParadiseSS13:master Jul 10, 2022
github-actions bot added a commit that referenced this pull request Jul 10, 2022
@Inadvizable Inadvizable deleted the flashy-moves branch July 10, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants