[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor #18556

Sirryan2002 · 2022-07-25T01:34:22Z

What Does This PR Do

Does a few things

Adds new sprites for implant cases, the implant pad, and implanters
-Implant Pad + Case Sprite are of my own work
-New Implanters were sprited in TG Station #66722 by PestoVerde322
Refactors Implant Code, mostly all just cleanup, implantpad had a few changes, also put an autosurgeon sprite as the base implant icon state so that it's not broken in-game (I know this is "sprite debt" but broken icons cause significant client lag upon examination/display)
Removes the ID var on tracking implants as they did absolute jack shit
Ensures all Implants have implanters and implant cases defined in the code
Ports the Implantpad to TGUI
Fixes Labor Points Console broken since TGUI merge #18693

Why It's Good For The Game

Sometimes you just need to update some crusty ass sprites that have outlived their time period. Also it's nice to have more code brought up to modern styling standards.

Project Progression -> #18493 and #14968

Images of changes

Lovely Images

Next things on my shitlist after this PR

Implant Chair
Locater

Changelog

🆑
add: Adds implanters + implant cases for every implanter implant available
del: Removed ID setter on implantpad
tweak: Implant Pad is now TGUI instead of browserUI
imageadd: Implant Cases have new sprites
imageadd: Implanters have new sprites
/:cl:

tgui/packages/tgui/interfaces/ImplantPad.js

S34NW · 2022-07-25T15:21:45Z

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

Sirryan2002 · 2022-07-25T15:46:05Z

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

I really don't want to up the files changed on this PR by 30 files + a couple map edits, unless you mean just changing their name variable?

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>

S34NW · 2022-07-25T16:30:15Z

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

I really don't want to up the files changed on this PR by 30 files + a couple map edits, unless you mean just changing their name variable?

Yeah just renaming them to the end user, coders will already know it's a different item.

S34NW · 2022-07-25T16:32:51Z

You could, for example, call them "microchips" or something

Sirryan2002 · 2022-07-25T16:56:37Z

You could, for example, call them "microchips" or something

Would prefer to change the name of cybernetik implants over changing these ones. That will need to be done in a separate PR

…o implanttgui

code/game/objects/items/weapons/implants/implant.dm

code/game/objects/items/weapons/implants/implantfluff.dm

Sirryan2002 · 2022-08-01T16:20:59Z

will try and get to this soonish

…o implanttgui

lewcc

Mostly nits, especially some of the stuff with the fluff. Looks good in general.

code/game/objects/items/weapons/implants/implant.dm

code/game/objects/items/weapons/implants/implant_adrenalin.dm

code/game/objects/items/weapons/implants/implant_death_alarm.dm

code/game/objects/items/weapons/implants/implant_dust.dm

code/game/objects/items/weapons/implants/implantcase.dm

code/game/objects/items/weapons/implants/implantfluff.dm

Sirryan2002 · 2022-08-07T18:26:12Z

Will have requested changes done in the next 3-4 days. Currently dealing with a 40 hour work week 💀

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

SteelSlayer

Partial review for now.

I didn't want spam suggestions for calling . = ..() at the start of Initialize(), but can you could please go over all the places where you changed /New to /Initialize and make that change?

code/game/machinery/computer/prisoner.dm

code/game/objects/items/weapons/implants/implant_abductor.dm

code/game/objects/items/weapons/implants/implant_dust.dm

code/game/machinery/computer/prisoner.dm

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com> Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

…o implanttgui

Sirryan2002 · 2022-08-25T02:40:11Z

still need to fix issues with uplink implants due to conflicts

Sirryan2002 · 2022-08-30T03:18:24Z

I promise I'm not forgetting about this PR, just working through early university setup stuff atm

…o implanttgui

hal9000PR

this + steels comments please.

code/game/objects/items/weapons/implants/implant.dm

code/game/objects/items/weapons/implants/implantcase.dm

code/game/objects/items/weapons/implants/implantchair.dm

code/game/objects/items/weapons/implants/implant.dm

code/game/objects/items/weapons/implants/implant_abductor.dm

code/game/objects/items/weapons/implants/implant_uplink.dm

tgui/packages/tgui/interfaces/PrisonerImplantManager.js

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

holy guacamole

77bf218

ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jul 25, 2022

AffectedArc07 added Refactor This PR will clean up the code but have the same ingame outcome User Interface This PR modifies a user interface in the game TGUI This PR modifies TGUI, will conflict Project Progression labels Jul 25, 2022

ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jul 25, 2022

CinnamonSnowball reviewed Jul 25, 2022

View reviewed changes

tgui/packages/tgui/interfaces/ImplantPad.js Outdated Show resolved Hide resolved

TGUI capitilization

6442f03

Co-authored-by: Nathan Winters <100448493+CinnamonSnowball@users.noreply.github.com>

TGUI rebuild

a5b1601

github-actions bot added the Merge Conflict This PR is merge conflicted label Jul 26, 2022

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

3269d7b

…o implanttgui

moxian reviewed Jul 28, 2022

View reviewed changes

github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Jul 28, 2022

Sirryan2002 added 3 commits August 5, 2022 10:27

implements requested changes

b37ca61

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

90ffcc7

…o implanttgui

fixes

29b23ef

github-actions bot removed the Merge Conflict This PR is merge conflicted label Aug 5, 2022

lewcc reviewed Aug 5, 2022

View reviewed changes

Apply suggestions from code review

be6e810

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

SteelSlayer requested changes Aug 10, 2022

View reviewed changes

code/game/machinery/computer/prisoner.dm Show resolved Hide resolved

code/game/objects/items/weapons/implants/implant_abductor.dm Outdated Show resolved Hide resolved

code/game/objects/items/weapons/implants/implant_dust.dm Outdated Show resolved Hide resolved

github-actions bot added the Merge Conflict This PR is merge conflicted label Aug 15, 2022

S34NW reviewed Aug 17, 2022

View reviewed changes

code/game/machinery/computer/prisoner.dm Outdated Show resolved Hide resolved

Sirryan2002 and others added 3 commits August 18, 2022 14:25

Apply suggestions from code review

b45446b

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com> Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

fulfilling more requests

b4b8533

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

d9d59c1

…o implanttgui

github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Aug 25, 2022

Sirryan2002 added 3 commits August 31, 2022 09:45

uplink fixes

f0437df

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

497abc0

…o implanttgui

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

8bce02b

…o implanttgui

github-actions bot removed the Merge Conflict This PR is merge conflicted label Aug 31, 2022

init order stuff

1fb3cc7

hal9000PR requested changes Aug 31, 2022

View reviewed changes

charlies requested changes

ccd484d

Sirryan2002 requested a review from hal9000PR August 31, 2022 14:27

hal9000PR approved these changes Sep 2, 2022

View reviewed changes

hal9000PR requested a review from SteelSlayer September 2, 2022 17:42

SteelSlayer reviewed Sep 3, 2022

View reviewed changes

ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 3, 2022

Apply suggestions from code review

7bbe744

Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>

SteelSlayer approved these changes Sep 3, 2022

View reviewed changes

SteelSlayer merged commit 520b091 into ParadiseSS13:master Sep 3, 2022

Sirryan2002 deleted the implanttgui branch September 3, 2022 05:34

github-actions bot added a commit that referenced this pull request Sep 3, 2022

Updating GBP balances for #18556

d5c635c

This was referenced Sep 13, 2022

Implanters in box not implating and new implanters coming full and not implanting as well. #19037

Closed

List of Browser UIs able to be converted to TGUI #14968

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor #18556

[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor #18556

Sirryan2002 commented Jul 25, 2022 •

edited

Loading

S34NW commented Jul 25, 2022

Sirryan2002 commented Jul 25, 2022 •

edited

Loading

S34NW commented Jul 25, 2022

S34NW commented Jul 25, 2022

Sirryan2002 commented Jul 25, 2022

Sirryan2002 commented Aug 1, 2022

lewcc left a comment

Sirryan2002 commented Aug 7, 2022

SteelSlayer left a comment

Sirryan2002 commented Aug 25, 2022

Sirryan2002 commented Aug 30, 2022

hal9000PR left a comment

[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor #18556

[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor #18556

Conversation

Sirryan2002 commented Jul 25, 2022 • edited Loading

What Does This PR Do

Why It's Good For The Game

Images of changes

Next things on my shitlist after this PR

Changelog

S34NW commented Jul 25, 2022

Sirryan2002 commented Jul 25, 2022 • edited Loading

S34NW commented Jul 25, 2022

S34NW commented Jul 25, 2022

Sirryan2002 commented Jul 25, 2022

Sirryan2002 commented Aug 1, 2022

lewcc left a comment

Choose a reason for hiding this comment

Sirryan2002 commented Aug 7, 2022

SteelSlayer left a comment

Choose a reason for hiding this comment

Sirryan2002 commented Aug 25, 2022

Sirryan2002 commented Aug 30, 2022

hal9000PR left a comment

Choose a reason for hiding this comment

Sirryan2002 commented Jul 25, 2022 •

edited

Loading

Sirryan2002 commented Jul 25, 2022 •

edited

Loading