Refactors light switches, igniter switches, mass driver buttons, and crematoriums? #18683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffectedArc07
added
Refactor
ParadiseSS13-Bot
added
the
-Status: Awaiting review
Contrabang
reviewed
Aug 14, 2022
ParadiseSS13-Bot
added
the
Testmerge Active
hal9000PR
requested changes
Aug 18, 2022
|
Lightswitches are fucked |
ParadiseSS13-Bot
removed
the
Testmerge Active
ParadiseSS13-Bot
added
the
Testmerge Active
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
ParadiseSS13-Bot
added
Testmerge Active
hal9000PR
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR removes the signal logic from light switches, mass driver buttons and igniter buttons. It also refactors light switches to make them take their current area and not store a ref to the area or a snowflake on/off var. This also fixes an indent and doesnt make an area call
powerChange()* the amount of lightswitches in the area.This PR also refactors the crematorium ignition buttons and cleans up crematorium and morgue code. Good god its a mess, and you can clearly tell the crematorium button was copied from the lightswitch code. It also kills off a
for([x] in world)loop.Why It's Good For The Game
This is part of my goal to kill off the ingame signalling system, because its quite honestly insane at how badly made it is and how much it hurts. Its extra lag for no reason when we can accomplish this just fine with refs.
Testing
Changelog
🆑 AffectedArc07
add: Added a tiny bit of performance with light switches
/:cl: