Speeds up the preferences menu by 10x. No that is not hyperbole. #20034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffectedArc07
added
Refactor
|
STOP OPENING MY PRS AS DRAFTS |
|
lmao |
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
AffectedArc07
commented
Dec 28, 2022
|
Oh also to be clear thats not an isolated instance of this proc using a ton. |
farie82
approved these changes
Dec 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Speeds up opening the keybinds tab of the prefs menu, taking it from ~270ms to ~20ms, purely by moving the string concat operations to a list join.
BEFORE
AFTER
Why It's Good For The Game
One person's prefs menu using the full time allotment of over 5 ticks is disgusting.
Testing
Opened the prefs menu.
Changelog
🆑 AffectedArc07
add: Sped up the prefs menu
/:cl: