[s] Disposals now checks for density before expelling #22274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
|
Loony Toons'ing under a wall is kinda wacky. This is a good change. |
SteelSlayer
reviewed
Sep 10, 2023
ParadiseSS13-Bot
added
-Status: Awaiting review
Co-authored-by: SteelSlayer <42044220+SteelSlayer@users.noreply.github.com>
hal9000PR
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
When an unconnected disposals pipe tries to expel someone, it first checks for dense objects on the tile in front of it: If there is a dense objects on the tile in front of it, it will instead expel you on the tile with the pipe.
Fixes: #13249
Why It's Good For The Game
Currently you are able to bypass any door/window/non-turf dense object by placing an unconnected disposals trunk/pipe in front of it and getting into a chute, this PR aims to fix that.
Testing
Be a skrell with and RPD and tools
Point a disposals trunk into an airlock and add a chute to enter the trunk.
Enter the trunk.
Get thrown out of the trunk on the side of the airlock I started on, and not behind it.
Changelog
🆑
fix: Disposals now checks for density before expelling
/:cl: