Moves the can_leave_fibers var to /obj/item/clothing instead of being on /atom
#23005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGamerL
commented
Oct 23, 2023
GDNgit
suggested changes
Oct 23, 2023
DGamerL
changed the title
can_leave_fibers var to /obj/item instead of being on /atomcan_leave_fibers var to /obj/item/clothing instead of being on /atom
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
farie82
added
the
Refactor
ParadiseSS13-Bot
added
-Status: Awaiting review
Sirryan2002
approved these changes
Oct 25, 2023
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
ParadiseSS13-Bot
added
-Status: Awaiting merge
S34NW
approved these changes
Oct 26, 2023
Oyu07
pushed a commit
to Oyu07/Paradise
that referenced
this pull request
Jan 2, 2024
…eing on `/atom` (ParadiseSS13#23005) * Ezpz * GDN review * Belts aren't clothing * Update code/modules/clothing/clothing.dm Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com> --------- Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Moves a variable to a higher hierarchy, making it not be put on every atom.
Why It's Good For The Game
Makes VV a bit easier to read, while still working correctly
Testing
Tried to leave fibers on a door, checked that it still worked with a forensic scanner.
Changelog
NPFC