Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborg Damage, Movement, and Power Overhaul #25252

Merged
merged 69 commits into from
Jul 9, 2024

Conversation

BiancaWilkson
Copy link
Contributor

@BiancaWilkson BiancaWilkson commented Apr 24, 2024

What Does This PR Do

This PR will do a few things.

  • Adds damage slowdown to cyborgs, and increases their base movement speed.
  • Removes common instant stuns from cyborg combat.
  • Adds a tweaked stamina damage to cyborgs, caused by the things that would currently stun them.
  • Reworks how cyborgs without power, or power cells work by making it potentially lethal to run out of power, but giving the borg time to react to losing power, or a power cell.

Exact mechanics of the power overhaul works like this:
The behavior for being de-celled is being merged into running out of charge. Either way, when your power source is gone you begin taking stamina damage every cycle of Life(). Cyborgs in stamcrit need to reboot, and cannot properly reboot without a power source. If the borg doesn't get re-powered by the time it would reboot, they die.

On the movement speed side of the PR, cyborgs start with the normal human movement speed, but as their components take damage or they take stamina damage they slow down. Both damage slowdown effects stack with each other.

EMPs and Flashes no longer instantly stun cyborgs, instead they deal 70 and 50 stamina damage respectively. In return, emagged engineering cyborgs no longer get a special instant-stun arm, and have been downgraded to a normal stunbaton.

While disablers and batons won't deal their stamina damage, ballistic projectiles still would, namely beanbag shells and the C20R.

Reboot_chime sound source: Achievement Accomplish Jingle App UI by CogFireStudios -- https://freesound.org/s/619840/ -- License: Creative Commons 0
shut_down sound source: No battery by DAN2008 -- https://freesound.org/s/710280/ -- License: Creative Commons 0

Please tell me if this is about to get fullmerged, There's a hard-coded speed up since config updates don't work during testmerges.

Why It's Good For The Game

Cyborgs have been a very contentious part of Paradise for the entirety of their existence. Their balance is always in a weird spot, their design has always been in a weird spot, and the playerbase's opinion of them has always been in a weird spot. Especially since the combat rework, everyone generally agreed that cyborgs' instant stun combat was unfun and outdated.
The changes to power come from my experiences being a de-celled cyborg. It's the worst, and having it kill the player is way more preferable to being stuck there. This allows them to stay conscious, while still threatening them and putting them on a timer.

Testing

Some testing, but I need to do more when I actually finish it.

Changelog

🆑
add: Cyborgs can now take stamina damage instead of being instantly stunned, and will need to reboot.
tweak: Cyborgs are conscious but slowly die when out of power, or without a power cell
tweak: Cyborgs now move at full speed, and slow down when they take damage.
tweak: Cyborgs need a power source to be revived.
tweak: You can put dead things inside a recharger.
tweak: Emagged engineering cyborgs now have a regular baton, instead of an instant-stunning arm.
/:cl:

@S34NW S34NW added Feature This PR is a new addition to the game Balance This PR will modify how effective something is or isnt labels Apr 24, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally Configuration Change This PR changes the game configuration files. Please run via the host. labels Apr 24, 2024
@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Apr 24, 2024
BiancaWilkson and others added 3 commits April 24, 2024 10:09
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
@Daylight2
Copy link
Contributor

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Apr 24, 2024
@Fordoxia
Copy link
Contributor

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

No more funny stun arm ::)

@BiancaWilkson
Copy link
Contributor Author

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

Gonna update the description to make it more clear, my intent is that the normal sources of stamina damage like disablers and batons still won't be able to harm cyborgs, the stamina system will be used to replace the current ways to instant-stun borgs.

Copy link

graphite-app bot commented Jun 17, 2024

Graphite Automations

"Assign AA to relevant PRs" took an action on this PR • (06/17/24)

1 assignee was added to this PR based on S34N's automation.

@Sirryan2002 Sirryan2002 self-requested a review June 24, 2024 16:28
Copy link
Contributor

@Sirryan2002 Sirryan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few small things

BiancaWilkson and others added 5 commits June 27, 2024 01:32
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Copy link
Member

@hal9000PR hal9000PR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few things. then it should be GTM (after config changes)

BiancaWilkson and others added 5 commits July 8, 2024 19:23
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
@hal9000PR hal9000PR enabled auto-merge July 9, 2024 17:43
@hal9000PR hal9000PR added this pull request to the merge queue Jul 9, 2024
Merged via the queue into ParadiseSS13:master with commit ec88636 Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Configuration Change This PR changes the game configuration files. Please run via the host. Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sound This PR modifies the game sound Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.