-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syndie depot loses its GPS #26883
Syndie depot loses its GPS #26883
Conversation
Damn, guess Explorers are gonna have to explore a bit more now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this actually compiles and has the changes that is meant to have. Testing here is mandatory.
If you need some help with this, please reach out on Discord to a member of the development team.
I would prefer if their was some hint of which z level it was on, otherwise I am fine with this |
I know this is going to sound really goofy, but could you make the changelog a bit more descriptive, maybe even with some IC flavor? Something like:
Even if someone knows what a GPS signal and the depot is, the implications may not be clear to them. So something a bit more descriptive I think goes a long way. |
Since #26861 is now in, you'll need to merge master locally, with map hooks enabled. We don't have a ton of documentation on this yet, but all you need to do is run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling my approval and putting a Change Request on this change for now. This is just to prevent any accidental merges. Please follow the directions that @warriorstar-orion has given above.
2ef58fe
to
236642b
Compare
hope i did it well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open the map in SDMM and just hit "Save" with no other changes, then commit the map again. Since you removed the GPS from that tile, it now has the same things on it as other tiles, and SDMM needs to coalesce them into the same tile of type.
236642b
to
d980484
Compare
d980484
to
69cb2d5
Compare
so this is how mapping works. should be fine now |
What Does This PR Do
Removes GPS signal from depot.
Why It's Good For The Game
Explorers should explore a bit more, than just 1 ruin with an uplink inside. Will force them to fly around and look for it. It still stays on always_place, so.. not a big change, everyone will hunt down the space looking for it, but wasting 5 extra minutes.
Images of changes
Testing
Tested on a local.. everything is fine as expected.
Declaration
Changelog
🆑
del: Syndicate has figured out that placing a GPS beacon inside their supply depot, marking it as an easy target for BSA, was not the best idea. The area is still being a dainty bit for any explorer of the nearby sectors, so try your luck looking for it!
/:cl: