Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndie depot loses its GPS #26883

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

kyunkyunkyun
Copy link
Contributor

@kyunkyunkyun kyunkyunkyun commented Sep 23, 2024

What Does This PR Do

Removes GPS signal from depot.

Why It's Good For The Game

Explorers should explore a bit more, than just 1 ruin with an uplink inside. Will force them to fly around and look for it. It still stays on always_place, so.. not a big change, everyone will hunt down the space looking for it, but wasting 5 extra minutes.

Images of changes

image

Testing

Tested on a local.. everything is fine as expected.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image


Changelog

🆑
del: Syndicate has figured out that placing a GPS beacon inside their supply depot, marking it as an easy target for BSA, was not the best idea. The area is still being a dainty bit for any explorer of the nearby sectors, so try your luck looking for it!
/:cl:

@matttheficus
Copy link
Contributor

Damn, guess Explorers are gonna have to explore a bit more now

Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this actually compiles and has the changes that is meant to have. Testing here is mandatory.
If you need some help with this, please reach out on Discord to a member of the development team.

@kyunkyunkyun kyunkyunkyun requested a review from Burzah September 23, 2024 22:20
@Qwertytoforty
Copy link
Contributor

I would prefer if their was some hint of which z level it was on, otherwise I am fine with this

@warriorstar-orion
Copy link
Contributor

I know this is going to sound really goofy, but could you make the changelog a bit more descriptive, maybe even with some IC flavor? Something like:

The Syndicate has found the OFF switch on their GPS, and the Depot no longer shows up on sector scans. Better search thoroughly if you want to find it!

Even if someone knows what a GPS signal and the depot is, the implications may not be clear to them. So something a bit more descriptive I think goes a long way.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Sep 23, 2024
@kyunkyunkyun kyunkyunkyun changed the title Syndie depot loses it's GPS Syndie depot loses its GPS Sep 25, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 27, 2024
@warriorstar-orion
Copy link
Contributor

Since #26861 is now in, you'll need to merge master locally, with map hooks enabled. We don't have a ton of documentation on this yet, but all you need to do is run .\tools\hooks\Install.bat
before attempting to merge this branch with master.

Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling my approval and putting a Change Request on this change for now. This is just to prevent any accidental merges. Please follow the directions that @warriorstar-orion has given above.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Sep 27, 2024
@kyunkyunkyun
Copy link
Contributor Author

Since #26861 is now in, you'll need to merge master locally, with map hooks enabled. We don't have a ton of documentation on this yet, but all you need to do is run .\tools\hooks\Install.bat before attempting to merge this branch with master.

hope i did it well

Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open the map in SDMM and just hit "Save" with no other changes, then commit the map again. Since you removed the GPS from that tile, it now has the same things on it as other tiles, and SDMM needs to coalesce them into the same tile of type.

@kyunkyunkyun
Copy link
Contributor Author

Open the map in SDMM and just hit "Save" with no other changes, then commit the map again. Since you removed the GPS from that tile, it now has the same things on it as other tiles, and SDMM needs to coalesce them into the same tile of type.

so this is how mapping works. should be fine now

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 28, 2024
@Burzah Burzah added the Feature This PR is a new addition to the game label Sep 28, 2024
@Burzah Burzah enabled auto-merge September 28, 2024 22:32
@Burzah Burzah added this pull request to the merge queue Sep 28, 2024
Merged via the queue into ParadiseSS13:master with commit a422b25 Sep 28, 2024
12 checks passed
@kyunkyunkyun kyunkyunkyun deleted the depot-nerf branch September 29, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants