Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some unknown tgui change breaking station trait saving #26988

Merged

Conversation

Qwertytoforty
Copy link
Contributor

@Qwertytoforty Qwertytoforty commented Oct 5, 2024

What Does This PR Do

Makes station traits saving for next round work again

resolve #26983

Why It's Good For The Game

Bugs are bad, admin tools should work

Testing


Forced the traits. (Cybernetic, rave, carp.)
Loaded cybernetic, rave, carp next round, verified with breakpoints t hat they were loaded and not random generated

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed admins being unable to force station traits for next round
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 5, 2024
@silverplatedelta silverplatedelta added the Fix This PR will fix an issue in the game label Oct 5, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Oct 5, 2024
@Contrabang Contrabang added this pull request to the merge queue Oct 6, 2024
Merged via the queue into ParadiseSS13:master with commit 1d447c5 Oct 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Station Traits is broken
4 participants