Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying terraform targets #14

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Add support for specifying terraform targets #14

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed9eb14
Use library functions for parsing boolean inputs
Nov 30, 2021
a4054a8
Add support for specifying terraform targets
Nov 30, 2021
0d7d689
Do not delete workspace when targets are specified
Nov 30, 2021
b6167f9
Use actions/core's getMultilineInput
Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ inputs:
required: false
description: Limit the number of concurrent operations during plan/apply
default: '10'
terraform_targets:
required: false
description: 'A comma separated string containing targets that should be passed to terraform. For example: foo,bar["one"],bar["two"]'
EvyBongers marked this conversation as resolved.
Show resolved Hide resolved
terraform_variables:
required: false
description: 'A JSON string containing variables that should be passed to terraform. For example: {"my_var": "my_value"}'
Expand Down
20 changes: 10 additions & 10 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5240,10 +5240,14 @@ async function terraform(args) {

(async () => {
const terraformDirectory = core.getInput('terraform_directory');
let terraformDoApply = core.getInput('terraform_do_apply') === 'true';
let terraformDoDestroy = core.getInput('terraform_do_destroy') === 'true';
const terraformLock = core.getInput('terraform_lock');
let terraformDoApply = core.getBooleanInput('terraform_do_apply');
let terraformDoDestroy = core.getBooleanInput('terraform_do_destroy');
const terraformLock = core.getBooleanInput('terraform_lock');
const terraformParallelism = core.getInput('terraform_parallelism');
const terraformTargets = core.getInput('terraform_targets')
.split(',')
.filter(_str => _str.trim() !== '')
.map(_str => `-target '${_str.trim()}'`);
const terraformVariables = core.getInput('terraform_variables');
const terraformWorkspace = core.getInput('terraform_workspace');

Expand All @@ -5258,10 +5262,6 @@ async function terraform(args) {
let tf_workspace_deletion = status_skipped;

core.startGroup('Sanity checking inputs');
if (terraformLock !== 'true' && terraformLock !== 'false') {
core.setFailed(`Sanity checks failed. Unknown value for 'terraform_lock': ${terraformLock}`);
process.exit(1);
}
if (/^\d+$/.test(terraformParallelism) === false) {
core.setFailed(`Sanity checks failed. Non-integer value for 'terraform_parallelism': ${terraformParallelism}`);
process.exit(1);
Expand Down Expand Up @@ -5379,7 +5379,7 @@ async function terraform(args) {
}

core.startGroup('Run terraform plan');
const tfp = await terraform(['plan', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-out=terraform.plan']);
const tfp = await terraform(['plan', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-out=terraform.plan'].concat(terraformTargets));
core.endGroup();
if (tfp.status > 0) {
tf_plan = status_failed;
Expand All @@ -5391,7 +5391,7 @@ async function terraform(args) {

core.startGroup('Run terraform apply');
if (terraformDoApply === true) {
const tfa = await terraform(['apply', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve', 'terraform.plan']);
const tfa = await terraform(['apply', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve', 'terraform.plan'].concat(terraformTargets));
core.endGroup();
if (tfa.status > 0) {
tf_apply = status_failed;
Expand All @@ -5407,7 +5407,7 @@ async function terraform(args) {
/* DESTROY START */
core.startGroup('Run terraform destroy');
if (terraformDoDestroy === true) {
const tfd = await terraform(['destroy', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve']);
const tfd = await terraform(['destroy', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve'].concat(terraformTargets));
core.info(tfd.stdout);
core.endGroup();
if (tfd.status > 0) {
Expand Down
20 changes: 10 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,14 @@ async function terraform(args) {

(async () => {
const terraformDirectory = core.getInput('terraform_directory');
let terraformDoApply = core.getInput('terraform_do_apply') === 'true';
let terraformDoDestroy = core.getInput('terraform_do_destroy') === 'true';
const terraformLock = core.getInput('terraform_lock');
let terraformDoApply = core.getBooleanInput('terraform_do_apply');
let terraformDoDestroy = core.getBooleanInput('terraform_do_destroy');
const terraformLock = core.getBooleanInput('terraform_lock');
Comment on lines +42 to +44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this method by chance. It validates values against the YAML 1.2 "Core Schema" specification.
https://github.com/actions/toolkit/blob/main/packages/core/src/core.ts#L161-L181

const terraformParallelism = core.getInput('terraform_parallelism');
const terraformTargets = core.getInput('terraform_targets')
.split(',')
.filter(_str => _str.trim() !== '')
.map(_str => `-target '${_str.trim()}'`);
EvyBongers marked this conversation as resolved.
Show resolved Hide resolved
const terraformVariables = core.getInput('terraform_variables');
const terraformWorkspace = core.getInput('terraform_workspace');

Expand All @@ -57,10 +61,6 @@ async function terraform(args) {
let tf_workspace_deletion = status_skipped;

core.startGroup('Sanity checking inputs');
if (terraformLock !== 'true' && terraformLock !== 'false') {
core.setFailed(`Sanity checks failed. Unknown value for 'terraform_lock': ${terraformLock}`);
process.exit(1);
}
Comment on lines -60 to -63
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsoleted by using core.getBooleanInput.

if (/^\d+$/.test(terraformParallelism) === false) {
core.setFailed(`Sanity checks failed. Non-integer value for 'terraform_parallelism': ${terraformParallelism}`);
process.exit(1);
Expand Down Expand Up @@ -178,7 +178,7 @@ async function terraform(args) {
}

core.startGroup('Run terraform plan');
const tfp = await terraform(['plan', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-out=terraform.plan']);
const tfp = await terraform(['plan', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-out=terraform.plan'].concat(terraformTargets));
core.endGroup();
if (tfp.status > 0) {
tf_plan = status_failed;
Expand All @@ -190,7 +190,7 @@ async function terraform(args) {

core.startGroup('Run terraform apply');
if (terraformDoApply === true) {
const tfa = await terraform(['apply', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve', 'terraform.plan']);
const tfa = await terraform(['apply', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve', 'terraform.plan'].concat(terraformTargets));
core.endGroup();
if (tfa.status > 0) {
tf_apply = status_failed;
Expand All @@ -206,7 +206,7 @@ async function terraform(args) {
/* DESTROY START */
core.startGroup('Run terraform destroy');
if (terraformDoDestroy === true) {
const tfd = await terraform(['destroy', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve']);
const tfd = await terraform(['destroy', `-lock=${terraformLock}`, `-parallelism=${terraformParallelism}`, '-auto-approve'].concat(terraformTargets));
EvyBongers marked this conversation as resolved.
Show resolved Hide resolved
core.info(tfd.stdout);
core.endGroup();
if (tfd.status > 0) {
Expand Down