Field cleanup: Removal of unused attributes #1926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed some code in FieldSet that checked whether Fields were using the same grid (will be implemented another way in v4)
they aren't needed, and can re-considered/added back if needed in v4 development
Not used in codebase
Now that Field.__init__ has explicit kwargs, no need to test
VeckoTheGecko
force-pushed
the
1844-field-cleanup
branch
from
0ea6cc6 to
c2cc573
Compare
erikvansebille
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove Field.filebuffername
remove Field.filebuffers
remove pointers from Field back to FieldSet
remove
creation_logfrom Fieldremove storing of
dimensionsdict on Field objectMake data_full_zdim explicit kwarg in Field
Chose the correct base branch (
v4-dev)xref Create an inventory of features to drop in v4 #1844